* [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver
@ 2018-08-17 20:16 Sergei Shtylyov
2018-08-17 20:19 ` [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-08-17 20:16 UTC (permalink / raw)
To: Wolfram Sang, Ulf Hansson, linux-mmc; +Cc: linux-renesas-soc
Hello!
Here's a set of 2 patches against the 'next' branch of Ulf Hannsson's 'mmc.git' repo.
They fix some typos I noticed...
[1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name
[2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo
MBR. Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name
2018-08-17 20:16 [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Sergei Shtylyov
@ 2018-08-17 20:19 ` Sergei Shtylyov
2018-08-20 16:47 ` Wolfram Sang
2018-08-21 13:21 ` Simon Horman
2018-08-17 20:20 ` [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo Sergei Shtylyov
2018-08-22 9:48 ` [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Ulf Hansson
2 siblings, 2 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-08-17 20:19 UTC (permalink / raw)
To: Wolfram Sang, Ulf Hansson, linux-mmc; +Cc: linux-renesas-soc
Fix a stray underscore in the DM_CM_DTRAN_MODE.BUS_WIDTH register field
name.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
===================================================================
--- mmc.orig/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -36,7 +36,7 @@
/* DM_CM_DTRAN_MODE */
#define DTRAN_MODE_CH_NUM_CH0 0 /* "downstream" = for write commands */
#define DTRAN_MODE_CH_NUM_CH1 BIT(16) /* "uptream" = for read commands */
-#define DTRAN_MODE_BUS_WID_TH (BIT(5) | BIT(4))
+#define DTRAN_MODE_BUS_WIDTH (BIT(5) | BIT(4))
#define DTRAN_MODE_ADDR_MODE BIT(0) /* 1 = Increment address */
/* DM_CM_DTRAN_CTRL */
@@ -172,7 +172,7 @@ renesas_sdhi_internal_dmac_start_dma(str
struct mmc_data *data)
{
struct scatterlist *sg = host->sg_ptr;
- u32 dtran_mode = DTRAN_MODE_BUS_WID_TH | DTRAN_MODE_ADDR_MODE;
+ u32 dtran_mode = DTRAN_MODE_BUS_WIDTH | DTRAN_MODE_ADDR_MODE;
if (!dma_map_sg(&host->pdev->dev, sg, host->sg_len,
mmc_get_dma_dir(data)))
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name
2018-08-17 20:19 ` [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name Sergei Shtylyov
@ 2018-08-20 16:47 ` Wolfram Sang
2018-08-21 13:21 ` Simon Horman
1 sibling, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2018-08-20 16:47 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
On Fri, Aug 17, 2018 at 11:19:02PM +0300, Sergei Shtylyov wrote:
> Fix a stray underscore in the DM_CM_DTRAN_MODE.BUS_WIDTH register field
> name.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Yes, I noticed this, too recently
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name
2018-08-17 20:19 ` [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name Sergei Shtylyov
2018-08-20 16:47 ` Wolfram Sang
@ 2018-08-21 13:21 ` Simon Horman
1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-08-21 13:21 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc
On Fri, Aug 17, 2018 at 11:19:02PM +0300, Sergei Shtylyov wrote:
> Fix a stray underscore in the DM_CM_DTRAN_MODE.BUS_WIDTH register field
> name.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo
2018-08-17 20:16 [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Sergei Shtylyov
2018-08-17 20:19 ` [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name Sergei Shtylyov
@ 2018-08-17 20:20 ` Sergei Shtylyov
2018-08-20 16:48 ` Wolfram Sang
2018-08-21 13:22 ` Simon Horman
2018-08-22 9:48 ` [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Ulf Hansson
2 siblings, 2 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-08-17 20:20 UTC (permalink / raw)
To: Wolfram Sang, Ulf Hansson, linux-mmc; +Cc: linux-renesas-soc
Fix the typo in the comment to #define DTRAN_MODE_CH_NUM_CH1.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
===================================================================
--- mmc.orig/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -35,7 +35,7 @@
/* DM_CM_DTRAN_MODE */
#define DTRAN_MODE_CH_NUM_CH0 0 /* "downstream" = for write commands */
-#define DTRAN_MODE_CH_NUM_CH1 BIT(16) /* "uptream" = for read commands */
+#define DTRAN_MODE_CH_NUM_CH1 BIT(16) /* "upstream" = for read commands */
#define DTRAN_MODE_BUS_WIDTH (BIT(5) | BIT(4))
#define DTRAN_MODE_ADDR_MODE BIT(0) /* 1 = Increment address */
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo
2018-08-17 20:20 ` [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo Sergei Shtylyov
@ 2018-08-20 16:48 ` Wolfram Sang
2018-08-21 13:22 ` Simon Horman
1 sibling, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2018-08-20 16:48 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Fri, Aug 17, 2018 at 11:20:23PM +0300, Sergei Shtylyov wrote:
> Fix the typo in the comment to #define DTRAN_MODE_CH_NUM_CH1.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
...but I really think those two patches should be squashed. One patch
per typo is too fine grained IMO.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo
2018-08-17 20:20 ` [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo Sergei Shtylyov
2018-08-20 16:48 ` Wolfram Sang
@ 2018-08-21 13:22 ` Simon Horman
1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-08-21 13:22 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Wolfram Sang, Ulf Hansson, linux-mmc, linux-renesas-soc
On Fri, Aug 17, 2018 at 11:20:23PM +0300, Sergei Shtylyov wrote:
> Fix the typo in the comment to #define DTRAN_MODE_CH_NUM_CH1.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver
2018-08-17 20:16 [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Sergei Shtylyov
2018-08-17 20:19 ` [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name Sergei Shtylyov
2018-08-17 20:20 ` [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo Sergei Shtylyov
@ 2018-08-22 9:48 ` Ulf Hansson
2 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2018-08-22 9:48 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Wolfram Sang, linux-mmc@vger.kernel.org, Linux-Renesas
On 17 August 2018 at 22:16, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello!
>
> Here's a set of 2 patches against the 'next' branch of Ulf Hannsson's 'mmc.git' repo.
> They fix some typos I noticed...
>
> [1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name
> [2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo
>
> MBR. Sergei
Thanks, squashed and queued for v4.20!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-08-22 13:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 20:16 [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Sergei Shtylyov
2018-08-17 20:19 ` [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: fix typo in DM_CM_DTRAN_MODE.BUS_WIDTH field name Sergei Shtylyov
2018-08-20 16:47 ` Wolfram Sang
2018-08-21 13:21 ` Simon Horman
2018-08-17 20:20 ` [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo Sergei Shtylyov
2018-08-20 16:48 ` Wolfram Sang
2018-08-21 13:22 ` Simon Horman
2018-08-22 9:48 ` [PATCH 0/2] Fix some typos in Renesas R-Car gen3 SDHI driver Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).