From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH v3 0/3] mmc: tmio: fix reset operation
Date: Thu, 1 Nov 2018 00:05:51 +0100 [thread overview]
Message-ID: <20181031230554.1660-1-niklas.soderlund@ragnatech.se> (raw)
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Hi,
While looking at the Renesas BSP kernel I found patches which improves
the state of the hardware at probe and after runtime resume.
Patch 1/3 make sure the module clock is enabled after resuming before
register are accessed. Patch 2/3 is the real change in this series and
brings in reset of the vendor specific callback when resetting (SCC in
the Renesas case). While 3/3 simply make sure that the IRQ mask for
Renesas boards (Gen2 and later) are in a good shape after probe (and
reset).
In addition to addressing the state after resuming it helped unbreak a
SD card I have which are very problematic on Koelsch. Without this
series inserting the card results in:
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
sh_mobile_sdhi ee100000.sd: Tuning procedure failed
mmc0: tuning execution failed: -5
mmc0: error -5 whilst initialising SD card
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
While with this series applied (patch 2/3):
sh_mobile_sdhi ee100000.sd: timeout waiting for hardware interrupt (CMD19)
mmc0: new ultra high speed SDR50 SDHC card at address aaaa
mmcblk0: mmc0:aaaa SU04G 3.69 GiB
mmcblk0: p1 p2
Patch 1/3 was previously part of 2/3 but as it deals with a unrelated
issue it's here broken out to a separate patch. Patch 3/3 have once been
posted outside this series bit after comments from Wolfram it's brought
back as it now deepens on 2/3.
Most changes in this series are based on similar work from Masaharu
Hayakawa but for this version all changes now differ quiet a lot from
his work. All mails sent to him bounce with a "Undelivered Mail
Returned to Sender" error. I therefor felt the need to claim authorship
as I don't want to post blame of my (potential) mistakes on some else.
Niklas Söderlund (3):
mmc: tmio: enable module clock before resetting when resuming
mmc: tmio: fix reset operation
mmc: renesas_sdhi: add initial setting of interrupt mask register
drivers/mmc/host/renesas_sdhi_core.c | 4 ++++
drivers/mmc/host/tmio_mmc.h | 1 +
drivers/mmc/host/tmio_mmc_core.c | 26 +++++++++++++++-----------
3 files changed, 20 insertions(+), 11 deletions(-)
--
2.19.1
next reply other threads:[~2018-11-01 8:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 23:05 Niklas Söderlund [this message]
2018-10-31 23:05 ` [PATCH v3 1/3] mmc: tmio: enable module clock before resetting when resuming Niklas Söderlund
2018-11-01 19:01 ` Wolfram Sang
2018-11-02 6:51 ` Masahiro Yamada
2018-11-02 11:58 ` Simon Horman
2018-10-31 23:05 ` [PATCH v3 2/3] mmc: tmio: fix reset operation Niklas Söderlund
2018-11-01 19:02 ` Wolfram Sang
2018-11-02 6:54 ` Masahiro Yamada
2018-11-26 16:53 ` Niklas Söderlund
2018-10-31 23:05 ` [PATCH v3 3/3] mmc: renesas_sdhi: add initial setting of interrupt mask register Niklas Söderlund
2018-11-01 19:02 ` Wolfram Sang
2018-11-02 12:02 ` Simon Horman
2018-11-01 19:04 ` [PATCH v3 0/3] mmc: tmio: fix reset operation Wolfram Sang
2018-11-01 19:35 ` Wolfram Sang
2018-11-19 12:08 ` Ulf Hansson
2018-11-19 12:14 ` Wolfram Sang
2018-11-19 13:08 ` Ulf Hansson
2018-11-19 13:33 ` Wolfram Sang
2018-11-19 17:28 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031230554.1660-1-niklas.soderlund@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox