From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH 3/3] i2c: rcar: wait for data empty before starting DMA
Date: Tue, 12 Mar 2019 13:50:38 +0100 [thread overview]
Message-ID: <20190312125038.6f55rmfmkkvimawg@ninjato> (raw)
In-Reply-To: <CAMuHMdWtNiLcOB_0vTa2nNM+tkdiTfYWP=VAe3GsfjRbxkgYvg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
> > + /* Check if DMA can be enabled and take over */
> > + if (priv->pos == 1 && rcar_i2c_dma(priv))
>
> Shouldn't you check if MSR.MAT is set?
It was set before, when priv->pos == 0.
>
> > + return;
>
> Hence ICMCR.ESG is not cleared, violating 57.3.8 (Master Transmit
> Operation), Step 3?
Clearing ESG is the very first thing we do in the ISR. Otherwise, we run
into the race issue we have on this HW and generate an unwanted repeated
message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-12 12:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 17:54 [PATCH 0/3] i2c: rcar: make DMA more robust Wolfram Sang
2019-03-05 17:54 ` [PATCH 1/3] i2c: rcar: sanity check for minimal DMA length Wolfram Sang
2019-03-11 9:49 ` Geert Uytterhoeven
2019-03-11 10:08 ` Geert Uytterhoeven
2019-03-12 12:58 ` Wolfram Sang
2019-03-15 12:56 ` Simon Horman
2019-03-20 17:20 ` Wolfram Sang
2019-03-05 17:54 ` [PATCH 2/3] i2c: rcar: let DMA enable routine return success status Wolfram Sang
2019-03-11 9:50 ` Geert Uytterhoeven
2019-03-15 13:02 ` Simon Horman
2019-03-20 17:20 ` Wolfram Sang
2019-03-05 17:54 ` [PATCH 3/3] i2c: rcar: wait for data empty before starting DMA Wolfram Sang
2019-03-11 9:59 ` Geert Uytterhoeven
2019-03-12 12:50 ` Wolfram Sang [this message]
2019-03-12 13:14 ` Geert Uytterhoeven
2019-03-12 13:18 ` Wolfram Sang
2019-03-12 13:56 ` Geert Uytterhoeven
2019-03-15 13:09 ` Simon Horman
2019-03-20 17:20 ` Wolfram Sang
2019-03-11 9:59 ` [PATCH 0/3] i2c: rcar: make DMA more robust Geert Uytterhoeven
2019-03-11 10:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312125038.6f55rmfmkkvimawg@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox