From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH i2c-tools 0/2] tools: improvements to handling restricted addresses
Date: Tue, 12 Mar 2019 16:50:05 +0100 [thread overview]
Message-ID: <20190312155005.GA1776@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20190311223335.18586-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
Thanks for your work.
On 2019-03-11 23:33:33 +0100, Wolfram Sang wrote:
> For debugging, I needed to use the restricted address range. That's when I
> noticed that the docs for i2ctransfer were missing an update (patch 1). But
> even more surprising, I noticed that the reserved addresses 0x03-0x07 were not
> restricted. It seems we all are so used to our lovely i2c-tools that nobody
> (including me) never questioned that :) But it should be fixed (patch 2), I
> think.
>
> Open for comments. Happy hacking!
I'm no expert in i2c but this matches my understanding of reserved
addresses in the specification, feel free to add for the whole series
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
>
> Wolfram Sang (2):
> tools: i2ctransfer: man: mention -a everywhere
> tools: restrict all addresses defined by the standard
>
> CHANGES | 2 ++
> tools/i2cbusses.c | 2 +-
> tools/i2cdetect.8 | 2 +-
> tools/i2cdetect.c | 2 +-
> tools/i2cdump.8 | 4 ++--
> tools/i2cdump.c | 2 +-
> tools/i2cget.8 | 4 ++--
> tools/i2cget.c | 2 +-
> tools/i2cset.8 | 4 ++--
> tools/i2cset.c | 2 +-
> tools/i2ctransfer.8 | 12 +++++++-----
> 11 files changed, 21 insertions(+), 17 deletions(-)
>
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2019-03-12 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 22:33 [PATCH i2c-tools 0/2] tools: improvements to handling restricted addresses Wolfram Sang
2019-03-11 22:33 ` [PATCH i2c-tools 1/2] tools: i2ctransfer: consequently document -a Wolfram Sang
2019-03-15 12:43 ` Jean Delvare
2019-03-17 21:23 ` Wolfram Sang
2019-04-23 21:13 ` Wolfram Sang
2019-03-11 22:33 ` [PATCH i2c-tools 2/2] tools: restrict all addresses defined by the standard Wolfram Sang
2019-03-15 13:24 ` Jean Delvare
2019-03-17 21:36 ` Wolfram Sang
2019-04-23 21:13 ` Wolfram Sang
2019-03-12 15:50 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312155005.GA1776@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox