From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52823C04AB1 for ; Sat, 11 May 2019 20:36:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14E2720989 for ; Sat, 11 May 2019 20:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iQxFzWoN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbfEKUga (ORCPT ); Sat, 11 May 2019 16:36:30 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:57702 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfEKUga (ORCPT ); Sat, 11 May 2019 16:36:30 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A74C12B6; Sat, 11 May 2019 22:36:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1557606987; bh=SbZkJJ8vo4OmG062o90zpWv9Wbc8FQI5/YgNhE98pMQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iQxFzWoN6xY9ohSfoGcSlnwE3CDwK+P0KddF3kjK5HNoQtSoXRYa3YjtYy1D2RMFf NYRjDGlkwihsVrK5piWG6pqldDZZ05MHFNTIoHCaUG2rX+GHcLb+HHw6GJMbp/0U7a JsyGMBt/js4301y2fBXWPMN5YrW8LahIq3Zc7g9Y= Date: Sat, 11 May 2019 23:36:11 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Andrzej Hajda Subject: Re: [PATCH/RFC 04/15] drm: bridge: Add dual_link field to the drm_bridge_timings structure Message-ID: <20190511203611.GP13043@pendragon.ideasonboard.com> References: <20190306232345.23052-1-laurent.pinchart+renesas@ideasonboard.com> <20190306232345.23052-5-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Kieran, On Wed, Apr 24, 2019 at 09:12:48AM +0100, Kieran Bingham wrote: > On 06/03/2019 23:23, Laurent Pinchart wrote: > > Extend the drm_bridge_timings structure with a new dual_link field to > > indicate that the bridge's input bus carries data on two separate > > physical links. The first use case is LVDS dual-link mode where even- > > and odd-numbered pixels are transferred on separate LVDS links. > > Do you foresee this becoming a bitfield in the future if there are more > options? > > I don't think that affects this right now though, and it's fine as a bool. I don't know yet. Maybe we'll combine this with other flags, maybe not. It's a bit of a ad-hoc parameter, if/when other link types require a similar feature, we'll likely refactor this. > > Signed-off-by: Laurent Pinchart > > Reviewed-by: Kieran Bingham > > > --- > > include/drm/drm_bridge.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > > index d4428913a4e1..aea1fcfd92a7 100644 > > --- a/include/drm/drm_bridge.h > > +++ b/include/drm/drm_bridge.h > > @@ -265,6 +265,14 @@ struct drm_bridge_timings { > > * input signal after the clock edge. > > */ > > u32 hold_time_ps; > > + /** > > + * @dual_link: > > + * > > + * True if the bus operates in dual-link mode. The exact meaning is > > + * dependent on the bus type. For LVDS buses, this indicates that even- > > + * and odd-numbered pixels are received on separate links. > > + */ > > + bool dual_link; > > }; > > > > /** -- Regards, Laurent Pinchart