From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6793C76186 for ; Sat, 27 Jul 2019 20:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9525A208E4 for ; Sat, 27 Jul 2019 20:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564261114; bh=3jvANDc9LliVkm8hGLHYQZv+x16Th48I4QDkZbmlC6g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=nPqjW/0y2s05GP5g465A91ZWkFu52Hzph5o/Pbn5s/YGlE2uNiuc2ExXDrdqOpZRR FP2vjH3WlJzDg/25fREO+vYklWENjAXvQXlWZ99BhcxBodGt7p3PEg0FsqCJW2vziq 6qPl9PXszw3lg96tV6x5v0CE/D0vQ+gW4yrKlsC0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388351AbfG0U6d (ORCPT ); Sat, 27 Jul 2019 16:58:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:53998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388150AbfG0U6d (ORCPT ); Sat, 27 Jul 2019 16:58:33 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B1912147A; Sat, 27 Jul 2019 20:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564261112; bh=3jvANDc9LliVkm8hGLHYQZv+x16Th48I4QDkZbmlC6g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=II9jiPzdrI+X4JBvEQZPZzwwbe8udv2GD1DPtQdcgt3uAUH42j6Ns4TjtF4+j3A52 t2RreywU7Fkp19ReS5PSHVd/GnVN6TX0e+/SXsiKLnJRCKVqM4iGw9cEuOTzxTxrVR UFYXnJK9yLozZQRP4wclydPjJBiHLgaAeZ3Dvc+4= Date: Sat, 27 Jul 2019 21:58:26 +0100 From: Jonathan Cameron To: Wolfram Sang Cc: Arnd Bergmann , Marek Vasut , stable@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Simon Horman , linux-renesas-soc@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kuninori Morimoto , Rob Herring , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] iio: adc: gyroadc: fix uninitialized return code Message-ID: <20190727215826.70212910@archlinux> In-Reply-To: <20190718140227.GA3813@kunai> References: <20190718135758.2672152-1-arnd@arndb.de> <20190718140227.GA3813@kunai> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, 18 Jul 2019 16:02:27 +0200 Wolfram Sang wrote: > On Thu, Jul 18, 2019 at 03:57:49PM +0200, Arnd Bergmann wrote: > > gcc-9 complains about a blatant uninitialized variable use that > > all earlier compiler versions missed: > > > > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] > > > > Return -EINVAL instead here and a few lines above it where > > we accidentally return 0 on failure. > > > > Cc: stable@vger.kernel.org > > Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver") > > Signed-off-by: Arnd Bergmann > > Yes, I checked the other error paths, too, and they look proper to me. > > Reviewed-by: Wolfram Sang > Thanks for sorting that second case as well. Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan