From: Wolfram Sang <wsa@the-dreams.de>
To: Ulrich Hecht <uli+renesas@fpond.eu>
Cc: linux-renesas-soc@vger.kernel.org, geert@linux-m68k.org,
fabrizio.castro@bp.renesas.com,
ramesh.shanmugasundaram@bp.renesas.com, magnus.damm@gmail.com
Subject: Re: [PATCH v2 0/3] clk: renesas: cpg-mssr: add ignore-unused option
Date: Wed, 18 Mar 2020 20:33:02 +0100 [thread overview]
Message-ID: <20200318193302.GA13309@ninjato> (raw)
In-Reply-To: <1584376479-25258-1-git-send-email-uli+renesas@fpond.eu>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
> The point of this is to allow a WDT that has been enabled by the bootloader
> to survive these events:
>
> - deferred probing of the WDT device, which can lead the clock driver
> to disable the WDT clock until the WDT is re-probed, giving it a
> blind spot
> - probe failure in the WDT driver
So, I was trying to test this with the watchdog driver and my patch[1].
To make the watchdog_register_device() call fail, I cleared the ident
struct:
priv->wdev.info = NULL; //&rwdt_ident;
Sadly, the watchdog does not fire after the driver bailed out of probe.
clk_summary rightfully says that the clock is neither prepared nor
enabled.
Did I miss something? I will try some more tomorrow.
Uli, how did you test the ignore_unused feature?
[1] https://patchwork.kernel.org/patch/11101573/
"[PATCH v2] watchdog: renesas_wdt: support handover from bootloader"
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-03-18 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 16:34 [PATCH v2 0/3] clk: renesas: cpg-mssr: add ignore-unused option Ulrich Hecht
2020-03-16 16:34 ` [PATCH v2 1/3] clk: renesas: cpg-mssr: add support for ignore-unused clocks Ulrich Hecht
2020-03-16 16:34 ` [PATCH v2 2/3] clk: renesas: rcar-gen3: mark RWDT clocks as ignore-unused Ulrich Hecht
2020-03-16 16:34 ` [PATCH v2 3/3] clk: renesas: rzg2: mark RWDT clock " Ulrich Hecht
2020-03-18 13:47 ` [PATCH v2 0/3] clk: renesas: cpg-mssr: add ignore-unused option Wolfram Sang
2020-03-18 19:33 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318193302.GA13309@ninjato \
--to=wsa@the-dreams.de \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
--cc=uli+renesas@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).