From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7E7C433E0 for ; Thu, 11 Jun 2020 03:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D2032070B for ; Thu, 11 Jun 2020 03:13:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D97W/Gq7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726312AbgFKDNj (ORCPT ); Wed, 10 Jun 2020 23:13:39 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:45494 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgFKDNj (ORCPT ); Wed, 10 Jun 2020 23:13:39 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D1B9726A; Thu, 11 Jun 2020 05:13:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1591845218; bh=gf2kFlEYfBFMvXqcwPSuWvy4Vc8G7zTgDOxH3ob7YPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D97W/Gq7kJTcWik8t2w6Q5KZ5uDAZiK8RX5DupR/1+Bk2FU3+Tj13ZQhyE9crDQrr 14EvDC8tAu1G2SRNl+FqOdrKA+KBvA+8l6xlC3mg/nkqRJpRNcxu6w2e4t+NSkgEjW l7p5OqXqpYzlitOS8/7rOC9o5YZg5FDafQNe4Y1A= Date: Thu, 11 Jun 2020 06:13:16 +0300 From: Laurent Pinchart To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 2/5] media-device: Add a complete flag to struct media_device Message-ID: <20200611031316.GF13598@pendragon.ideasonboard.com> References: <20200610230541.1603067-1-niklas.soderlund+renesas@ragnatech.se> <20200610230541.1603067-3-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200610230541.1603067-3-niklas.soderlund+renesas@ragnatech.se> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Niklas, Thank you for the patch. On Thu, Jun 11, 2020 at 01:05:38AM +0200, Niklas Söderlund wrote: > Add a complete flag to indicate if the media graph is complete or not. > The use-case is for v4l2-async to set the flag when all subdevices are > bound and that the flag be reported to user-space so it can learn when a > graph is completely populated. > > Signed-off-by: Niklas Söderlund > --- > include/media/media-device.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/media/media-device.h b/include/media/media-device.h > index fa089543072052cf..cd685c3a791c6c04 100644 > --- a/include/media/media-device.h > +++ b/include/media/media-device.h > @@ -83,6 +83,7 @@ struct media_device_ops { > * @serial: Device serial number (optional) > * @bus_info: Unique and stable device location identifier > * @hw_revision: Hardware device revision > + * @complete: Graph completed flag This requires more documentation too. > * @topology_version: Monotonic counter for storing the version of the graph > * topology. Should be incremented each time the topology changes. > * @id: Unique ID used on the last registered graph object > @@ -151,6 +152,7 @@ struct media_device { > char serial[40]; > char bus_info[32]; > u32 hw_revision; > + bool complete; > > u64 topology_version; > -- Regards, Laurent Pinchart