From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 4/5] mc-device.c: Report graph complete to user-space
Date: Thu, 11 Jun 2020 06:14:04 +0300 [thread overview]
Message-ID: <20200611031404.GG13598@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200610230541.1603067-5-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
Thank you for the patch.
On Thu, Jun 11, 2020 at 01:05:40AM +0200, Niklas Söderlund wrote:
> If the graph in the media device is complete report it to userspace by
> setting the MEDIA_TOPOLOGY_FLAG_COMPLETE flag.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/mc/mc-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> index c2ef5bb512a5fba0..d63792cc014279fc 100644
> --- a/drivers/media/mc/mc-device.c
> +++ b/drivers/media/mc/mc-device.c
> @@ -242,7 +242,7 @@ static long media_device_get_topology(struct media_device *mdev, void *arg)
> int ret = 0;
>
> topo->topology_version = mdev->topology_version;
> - topo->flags = 0;
> + topo->flags = mdev->complete ? MEDIA_TOPOLOGY_FLAG_COMPLETE : 0;
>
> /* Get entities and number of entities */
> i = 0;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-06-11 3:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 23:05 [PATCH 0/5] media-device: Report if graph is complete Niklas Söderlund
2020-06-10 23:05 ` [PATCH 1/5] uapi/linux/media.h: add flags field to struct media_v2_topology Niklas Söderlund
2020-06-11 3:12 ` Laurent Pinchart
2020-06-11 10:51 ` Sakari Ailus
2020-06-10 23:05 ` [PATCH 2/5] media-device: Add a complete flag to struct media_device Niklas Söderlund
2020-06-11 3:13 ` Laurent Pinchart
2020-06-10 23:05 ` [PATCH 3/5] v4l2-async: Flag when media graph is complete Niklas Söderlund
2020-06-11 3:10 ` Laurent Pinchart
2020-06-11 10:50 ` Sakari Ailus
2020-06-11 10:52 ` Sakari Ailus
2020-06-10 23:05 ` [PATCH 4/5] mc-device.c: Report graph complete to user-space Niklas Söderlund
2020-06-11 3:14 ` Laurent Pinchart [this message]
2020-06-10 23:05 ` [PATCH 5/5] rcar-vin: Do not unregister video device when a subdevice is unbound Niklas Söderlund
2020-06-11 8:56 ` Sergei Shtylyov
2020-06-12 10:45 ` [PATCH 0/5] media-device: Report if graph is complete Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611031404.GG13598@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox