From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 0/2] i2c: rcar: use iopoll helpers for better timeout handling
Date: Sun, 30 Aug 2020 10:30:11 +0200 [thread overview]
Message-ID: <20200830083011.GS594558@oden.dyn.berto.se> (raw)
In-Reply-To: <20200829203810.1467-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
Neat work, I learnt something new.
On 2020-08-29 22:38:08 +0200, Wolfram Sang wrote:
> Originally, I noticed that the timeout value for initiating bus recovery
> was not optimal. While fixing it, I took the chance to convert its
> handling to the iopoll helpers. And then, I converted the timeout
> handling for resetting the device, too, while I was at it.
>
> Tested on a Renesas Lager board (H2) and Salvator-XS (M3-N).
>
> Wolfram Sang (2):
> i2c: rcar: improve bus busy detection
> i2c: rcar: refactor and shorten timeout when resetting
For the whole series,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> drivers/i2c/busses/i2c-rcar.c | 34 +++++++++++++---------------------
> 1 file changed, 13 insertions(+), 21 deletions(-)
>
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2020-08-30 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 20:38 [PATCH 0/2] i2c: rcar: use iopoll helpers for better timeout handling Wolfram Sang
2020-08-29 20:38 ` [PATCH 1/2] i2c: rcar: improve bus busy detection Wolfram Sang
2020-09-09 8:44 ` Wolfram Sang
2020-08-29 20:38 ` [PATCH 2/2] i2c: rcar: refactor and shorten timeout when resetting Wolfram Sang
2020-09-09 8:44 ` Wolfram Sang
2020-08-30 8:30 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830083011.GS594558@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox