From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECBBC43461 for ; Tue, 8 Sep 2020 14:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CB3A223DB for ; Tue, 8 Sep 2020 14:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730085AbgIHOR6 (ORCPT ); Tue, 8 Sep 2020 10:17:58 -0400 Received: from mga03.intel.com ([134.134.136.65]:52218 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729785AbgIHOPv (ORCPT ); Tue, 8 Sep 2020 10:15:51 -0400 IronPort-SDR: iysYzGTVlrCO21GH6pdDwRLcvrg2KC1KMNeGLQJbsicE7TdweZm+h7V/RKesJZTB/UrAMJUMI+ gVg09E7ehyoA== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="158151634" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="158151634" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:29:51 -0700 IronPort-SDR: 6R3AzQjOcRIsdsz6fyEAXD/ifodzSuwmdsKH7KoS9y5ZxDAI+8yV154nTGA5wfuSmGHgzJQqBY EY0lmkrqArDw== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="304091179" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:29:48 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 8FDA2205C8; Tue, 8 Sep 2020 16:29:46 +0300 (EEST) Date: Tue, 8 Sep 2020 16:29:46 +0300 From: Sakari Ailus To: Jacopo Mondi Cc: Jacopo Mondi , robh+dt@kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, Leon Luo , Sowjanya Komatineni , mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v4 2/3] dt-bindings: media: imx274: Convert to json-schema Message-ID: <20200908132945.GA19532@paasikivi.fi.intel.com> References: <20200903115143.13717-1-jacopo+renesas@jmondi.org> <20200903115143.13717-3-jacopo+renesas@jmondi.org> <20200903122331.GJ32646@paasikivi.fi.intel.com> <20200903124831.okjegcpk7n7sshsn@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903124831.okjegcpk7n7sshsn@uno.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Jacopo, On Thu, Sep 03, 2020 at 02:48:31PM +0200, Jacopo Mondi wrote: > Hi Sakari > > On Thu, Sep 03, 2020 at 03:23:31PM +0300, Sakari Ailus wrote: > > Hi Jacopo, > > > > Thanks for the update. > > > > On Thu, Sep 03, 2020 at 01:51:42PM +0200, Jacopo Mondi wrote: > > > Convert the imx274 bindings document to json-schema and update > > > the MAINTAINERS file accordingly. > > > > > > Reviewed-by: Laurent Pinchart > > > Signed-off-by: Jacopo Mondi > > > --- > > > .../devicetree/bindings/media/i2c/imx274.txt | 38 ------------ > > > .../bindings/media/i2c/sony,imx274.yaml | 59 +++++++++++++++++++ > > > MAINTAINERS | 2 +- > > > 3 files changed, 60 insertions(+), 39 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > > > deleted file mode 100644 > > > index 0727079d2410..000000000000 > > > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > > > +++ /dev/null > > > @@ -1,38 +0,0 @@ > > > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor > > > - > > > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with > > > -an active array size of 3864H x 2202V. It is programmable through I2C > > > -interface. The I2C address is fixed to 0x1a as per sensor data sheet. > > > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes > > > -at 1440 Mbps. > > > - > > > - > > > -Required Properties: > > > -- compatible: value should be "sony,imx274" for imx274 sensor > > > -- reg: I2C bus address of the device > > > - > > > -Optional Properties: > > > -- reset-gpios: Sensor reset GPIO > > > -- clocks: Reference to the input clock. > > > -- clock-names: Should be "inck". > > > -- VANA-supply: Sensor 2.8v analog supply. > > > -- VDIG-supply: Sensor 1.8v digital core supply. > > > -- VDDL-supply: Sensor digital IO 1.2v supply. > > > - > > > -The imx274 device node should contain one 'port' child node with > > > -an 'endpoint' subnode. For further reading on port node refer to > > > -Documentation/devicetree/bindings/media/video-interfaces.txt. > > > - > > > -Example: > > > - sensor@1a { > > > - compatible = "sony,imx274"; > > > - reg = <0x1a>; > > > - #address-cells = <1>; > > > - #size-cells = <0>; > > > - reset-gpios = <&gpio_sensor 0 0>; > > > - port { > > > - sensor_out: endpoint { > > > - remote-endpoint = <&csiss_in>; > > > - }; > > > - }; > > > - }; > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > > new file mode 100644 > > > index 000000000000..f757ce380cb2 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > > @@ -0,0 +1,59 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor > > > + > > > +maintainers: > > > + - Leon Luo > > > + > > > +description: | > > > + The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an > > > + active array size of 3864H x 2202V. It is programmable through I2C interface. > > > + Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440 > > > + Mbps. > > > + > > > +properties: > > > + compatible: > > > + const: sony,imx274 > > > + > > > + reg: > > > + const: 0x1a > > > + > > > + reset-gpios: > > > + maxItems: 1 > > > + > > > + port: > > > + type: object > > > + description: | > > > + Output video port. See ../video-interfaces.txt. > > > + > > > > What happened to the supplies and the clocks? > > > > AH! > > 74ea3273d24b ("dt-bindings: media: imx274: Add optional input clock and supplies") > went in a release later than my v2. From there I kep carrying on what > I had in the yaml file in v3 and v4 without noticing the original > bindings in textual form had changed in between! Yes, it was merged via Rob's tree apparently, and now is in media tree, too. I wasn't quite expecting that. -- Sakari Ailus