From: Wang Li <wangli74@huawei.com>
To: <yoshihiro.shimoda.uh@renesas.com>, <kishon@ti.com>,
<vkoul@kernel.org>, <biju.das@bp.renesas.com>
Cc: <linux-renesas-soc@vger.kernel.org>, <wangli74@huawei.com>
Subject: [PATCH v2] phy: renesas: rcar-gen3-usb2: disable runtime pm in case of failure
Date: Thu, 26 Nov 2020 10:44:12 +0800 [thread overview]
Message-ID: <20201126024412.4046845-1-wangli74@huawei.com> (raw)
pm_runtime_enable() will decrease power disable depth. Thus a pairing
increment is needed on the error handling path to keep it balanced.
Fixes: 5d8042e95fd4 ("phy: rcar-gen3-usb2: Add support for r8a77470")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Li <wangli74@huawei.com>
---
Changelog:
v2
- Correct the commit message.
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
index e34e4475027c..2cb949f931b6 100644
--- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
@@ -656,8 +656,10 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
*/
pm_runtime_enable(dev);
phy_usb2_ops = of_device_get_match_data(dev);
- if (!phy_usb2_ops)
- return -EINVAL;
+ if (!phy_usb2_ops) {
+ ret = -EINVAL;
+ goto error;
+ }
mutex_init(&channel->lock);
for (i = 0; i < NUM_OF_PHYS; i++) {
--
2.25.4
next reply other threads:[~2020-11-26 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 2:44 Wang Li [this message]
2020-12-05 8:06 ` [PATCH v2] phy: renesas: rcar-gen3-usb2: disable runtime pm in case of failure Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126024412.4046845-1-wangli74@huawei.com \
--to=wangli74@huawei.com \
--cc=biju.das@bp.renesas.com \
--cc=kishon@ti.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox