From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB605C7EE29 for ; Fri, 2 Jun 2023 11:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235310AbjFBLgv (ORCPT ); Fri, 2 Jun 2023 07:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232455AbjFBLgv (ORCPT ); Fri, 2 Jun 2023 07:36:51 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77313194; Fri, 2 Jun 2023 04:36:44 -0700 (PDT) Received: from pendragon.ideasonboard.com (om126156168104.26.openmobile.ne.jp [126.156.168.104]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 443CE6E0; Fri, 2 Jun 2023 13:36:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1685705780; bh=P6UK7gokiOdLMcgnQqxLjRe/2stcZX5OnfxLzLL/M8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZXkiKfg3l/3Zn5Hs1rF1UqizLbyGjOovKGO5nYDa5CsXVzIhgdO0OuBQ8YgdHm38X Bxyh7d0X1/u80DgGvAuskxBTqQBbfDqWu2lEb7bY4nexWJTb+xXsdfxHTwRxJXd7mU s+9jbaqSxFpevXaFdQHCREWYp9j9SBrCMzFprxoM= Date: Fri, 2 Jun 2023 14:36:40 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Jyri Sarha , Tomi Valkeinen , Biju Das , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm: Remove references to removed transitional helpers Message-ID: <20230602113640.GG26944@pendragon.ideasonboard.com> References: <14e091fc522aa63a3e33bda1016e5fa946d47d18.1685696114.git.geert+renesas@glider.be> <20230602110459.GC26944@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, On Fri, Jun 02, 2023 at 01:17:58PM +0200, Geert Uytterhoeven wrote: > On Fri, Jun 2, 2023 at 1:05 PM Laurent Pinchart wrote: > > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > > The transitional helpers were removed a long time ago, but some > > > references stuck. Remove them. > > > > > > Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") > > > Signed-off-by: Geert Uytterhoeven > > > > --- a/drivers/gpu/drm/drm_plane_helper.c > > > +++ b/drivers/gpu/drm/drm_plane_helper.c > > > @@ -51,14 +51,6 @@ > > > * planes, and newly merged drivers must not rely upon these transitional > > > * helpers. > > > * > > > > The first paragraph starts with "This helper library has two parts.". As > > you're dropping the mention of the second part, I think you should > > rework the first paragraph too. > > That was my initial thought, too. > However, the code still has a second part, not related to the topic of > the first part (primary plane support). How about mentioning that in the comment then ? > > > - * The second part also implements transitional helpers which allow drivers to > > > - * gradually switch to the atomic helper infrastructure for plane updates. Once > > > - * that switch is complete drivers shouldn't use these any longer, instead using > > > - * the proper legacy implementations for update and disable plane hooks provided > > > - * by the atomic helpers. > > > - * > > > - * Again drivers are strongly urged to switch to the new interfaces. > > > - * > > > * The plane helpers share the function table structures with other helpers, > > > * specifically also the atomic helpers. See &struct drm_plane_helper_funcs for > > > * the details. -- Regards, Laurent Pinchart