Re: [PATCH 2/2] ARM: dts: armadillo800eva: Add LCD panel

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

Thank you for the patch.

On Thu, Jun 22, 2023 at 11:23:15AM +0200, Geert Uytterhoeven wrote:
> Describe the 5" WVGA TFT LCD panel on the Armadillo-800-EVA development
> board, and enable the LCD controller that drives it.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 28 +++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 101413d5164913c5..fb6b432c4df2d948 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> @@ -132,7 +132,7 @@ i2c2: i2c-2 {
>  		i2c-gpio,delay-us = <5>;
>  	};
>  
> -	backlight {
> +	backlight: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>;
>  		brightness-levels = <0 1 2 4 8 16 32 64 128 255>;
> @@ -143,6 +143,18 @@ backlight {
>  		enable-gpios = <&pfc 61 GPIO_ACTIVE_HIGH>;
>  	};
>  
> +	panel {
> +		compatible = "ampire,am-800480l1tmqw-t00h";
> +		backlight = <&backlight>;
> +		power-supply = <&reg_5p0v>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&lcdc0_rgb>;
> +			};
> +		};
> +	};
> +
>  	sound {
>  		compatible = "simple-audio-card";
>  
> @@ -228,10 +240,22 @@ rtc@30 {
>  	};
>  };
>  
> -&pfc {
> +&lcdc0 {
>  	pinctrl-0 = <&lcd0_pins>;
>  	pinctrl-names = "default";
>  
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			endpoint {
> +				remote-endpoint = <&panel_in>;
> +			};
> +		};
> +	};
> +};
> +
> +&pfc {
>  	ether_pins: ether {
>  		groups = "gether_mii", "gether_int";
>  		function = "gether";

-- 
Regards,

Laurent Pinchart