From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78736EB64D9 for ; Fri, 7 Jul 2023 10:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232033AbjGGKir (ORCPT ); Fri, 7 Jul 2023 06:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjGGKiq (ORCPT ); Fri, 7 Jul 2023 06:38:46 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB981725 for ; Fri, 7 Jul 2023 03:38:45 -0700 (PDT) Received: from pendragon.ideasonboard.com (85-76-32-136-nat.elisa-mobile.fi [85.76.32.136]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 52041558; Fri, 7 Jul 2023 12:37:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1688726278; bh=L9/7Bf1eunm2Dl68BqIQkXOmHFdcsKoWUkQaUcSx31o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N6pkPaEaG7vdw93D4DkYUYslGB8jIUyby7a+6YME5c+aS/azfITmSkP/Rwj0oar4R It7hQz7OZvwemQ17S7vg2QsHVKAZpzI0ivnrQ5Y44U2FvOJyty0tVa29tICsYu6a66 X//KMAG/f/3DemM1LJydjoeW5Ixg4Mm6SaKfAlBY= Date: Fri, 7 Jul 2023 13:38:41 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH libdrm 3/3] modetest: Add support for DRM_FORMAT_NV{24,42} Message-ID: <20230707103841.GC15801@pendragon.ideasonboard.com> References: <1e43eba23f3a73ed4c18ec4516869a5abc39a475.1688570702.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1e43eba23f3a73ed4c18ec4516869a5abc39a475.1688570702.git.geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, Thank you for the patch. On Wed, Jul 05, 2023 at 05:26:17PM +0200, Geert Uytterhoeven wrote: > Add support for creating buffers using semi-planar YUV formats with > non-subsampled chroma planes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > tests/modetest/buffers.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c > index 0b55aeddfef9a854..0605b12552bb8eec 100644 > --- a/tests/modetest/buffers.c > +++ b/tests/modetest/buffers.c > @@ -129,6 +129,8 @@ bo_create(int fd, unsigned int format, > case DRM_FORMAT_NV21: > case DRM_FORMAT_NV16: > case DRM_FORMAT_NV61: > + case DRM_FORMAT_NV24: > + case DRM_FORMAT_NV42: > case DRM_FORMAT_YUV420: > case DRM_FORMAT_YVU420: > bpp = 8; > @@ -208,6 +210,11 @@ bo_create(int fd, unsigned int format, > virtual_height = height * 2; > break; > > + case DRM_FORMAT_NV24: > + case DRM_FORMAT_NV42: > + virtual_height = height * 3; > + break; > + > default: > virtual_height = height; > break; > @@ -255,6 +262,19 @@ bo_create(int fd, unsigned int format, > planes[1] = virtual + offsets[1]; > break; > > + case DRM_FORMAT_NV24: > + case DRM_FORMAT_NV42: > + offsets[0] = 0; > + handles[0] = bo->handle; > + pitches[0] = bo->pitch; > + pitches[1] = pitches[0] * 2; > + offsets[1] = pitches[0] * height; > + handles[1] = bo->handle; > + > + planes[0] = virtual; > + planes[1] = virtual + offsets[1]; > + break; > + > case DRM_FORMAT_YUV420: > case DRM_FORMAT_YVU420: > offsets[0] = 0; -- Regards, Laurent Pinchart