From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F9E31C6B4; Sat, 4 Jan 2025 12:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735993028; cv=none; b=kIT/mBYicKYvNxMp0UYyXgTJH+zFStMiW6U+isnNdYknFoiY8ka9O7tPVfxtUBP8n7LBsh5nFtcUvbC3Y3A9XJz5JB4XKOHMnjeQKRfT9KQ03EVK5Uj4KZ+xp6z7YuHdUdU7KhscvheYKLoMwgfT6WQWM9D3nUqT/wt1P6RDSGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735993028; c=relaxed/simple; bh=nzLsC49a7ezLLhHwHH3aykDJkZfd8qgg6IsgB2XUF3A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HMhcOHPhTkG3Zeb44bQxZYziVuwOCleaV7bCrXIMK/hDgT3Ss8xXaqPfjdoH2OTwgOPVuCK91nyCSV5OaBZgWqDybb/w9d4d8PG8vMHogsmVKQBDMnO43dp66As05d+DxLs8QPxqXJ4IuyBFo2YBgNOaSgzprTR617dqj6o2AFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=cTJxcCFZ; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Kj1u2oTU; arc=none smtp.client-ip=202.12.124.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="cTJxcCFZ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Kj1u2oTU" Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id B09CB1140198; Sat, 4 Jan 2025 07:17:04 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Sat, 04 Jan 2025 07:17:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1735993024; x=1736079424; bh=ydRMRC5sukqcVXq7NeTrGn3Yt8Z8JWUbqZOa1AQ+niM=; b= cTJxcCFZ8ME94m16B4rRoAZM6QkNa2YtCUD+5ONliE2BoMoLw/BpTgNQrJ9pNiL0 tW4LB54A/4U93gugCf/mhInOiazIe3eaXBDmElZuG60mdqDgtgYt+wZfhh/zZ3qY 5IUOGvsjPwVwffh3DEq81IXLPlSphtpPhzHFSw/hQQEDahPW6kJ81Puv0LxyZODi YpPQw4pqVa/1KAGPS2laJ7nab65sc/WHBYTYzm/DcxUFGL/jUtfEg3cgU7gW3pbw jq4arWnPpdN/xjyHJzDYovSzzPq1229IvfEho7hRaV0bGzbR92wSsQ+VVj3eW4sX 9XpsiOF3/v4Gc21PZcD8AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735993024; x= 1736079424; bh=ydRMRC5sukqcVXq7NeTrGn3Yt8Z8JWUbqZOa1AQ+niM=; b=K j1u2oTUALCfY+mCJSUym6VZQjfCOYeJ7IZeZxs+1Do8Et7lkQKTYdNXSmJXG9aQW 5nwiwMFznUuEYHhfz0tbk//PkE+Pj6Zo3mgnud/k13gLYPrzkMaXjXVAskVbYlP/ 1mccQSaaXVQ1MPvZfWXjO2dONtu8G+X2fe5nL8uFY463x/5eCPpWoHcrZDtynwI5 fQU2SV/1HdH0W/tNFka2UvP/i5cDne9qfZ1uIy7hAuJEKuAnc2I9UnzY02ymzkp+ /7gja8uVqji+7Srnk2kqTpG6t2zxaQjmQf3RoOOKQCKxOTibDOytwbBZaS0TWEiW IZGnhUQF65X48YUGuVwXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudefiedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdej necuhfhrohhmpefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhoug gvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrshgvqeenucggtffrrght thgvrhhnpeefhfellefhffejgfefudfggeejlefhveehieekhfeulefgtdefueehffdtvd elieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehn ihhklhgrshdrshhouggvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrsh gvpdhnsggprhgtphhtthhopeduuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep ghgvvghrtheslhhinhhugidqmheikehkrdhorhhgpdhrtghpthhtohepshgrkhgrrhhird grihhluhhssehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepmhgthhgvhhgr sgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprhhosghhsehkvghrnhgvlhdrohhrgh dprhgtphhtthhopehkrhiikhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegt ohhnohhrodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepghgvvghrthdorhgvnh gvshgrshesghhlihguvghrrdgsvgdprhgtphhtthhopehlrghurhgvnhhtrdhpihhntghh rghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtoheplhhinhhugidqmh gvughirgesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 4 Jan 2025 07:17:03 -0500 (EST) Date: Sat, 4 Jan 2025 13:17:00 +0100 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Geert Uytterhoeven Cc: Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 3/4] arm64: dts: renesas: white-hawk-csi-dsi: Define CSI-2 data line orders Message-ID: <20250104121700.GF808684@ragnatech.se> References: <20241121134108.2029925-1-niklas.soderlund+renesas@ragnatech.se> <20241121134108.2029925-4-niklas.soderlund+renesas@ragnatech.se> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Geert, Thanks for your feedback. On 2024-12-27 14:22:31 +0100, Geert Uytterhoeven wrote: > Hi Niklas, Sakari, Mauro, > > On Thu, Nov 21, 2024 at 2:41 PM Niklas Söderlund > wrote: > > The second CSI-2 C-PHY data-lane have a different line order (BCA) then > > the two other data-lanes (ABC) for both connected CSI-2 receivers, > > describe this in the device tree. > > > > This have worked in the past as the R-Car CSI-2 driver did not have > > has > > > documentation for the line order configuration and a magic value was > > written to the register for this specific setup. Now the registers > > involved are documented and the hardware description as well as the > > driver needs to be corrected. > > > > Signed-off-by: Niklas Söderlund > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven > > > --- a/arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi > > +++ b/arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi > > @@ -21,6 +21,9 @@ csi40_in: endpoint { > > bus-type = ; > > clock-lanes = <0>; > > data-lanes = <1 2 3>; > > + line-orders = > + MEDIA_BUS_CSI2_CPHY_LINE_ORDER_BCA > > + MEDIA_BUS_CSI2_CPHY_LINE_ORDER_ABC>; > > remote-endpoint = <&max96712_out0>; > > }; > > }; > > @@ -41,6 +44,9 @@ csi41_in: endpoint { > > bus-type = ; > > clock-lanes = <0>; > > data-lanes = <1 2 3>; > > + line-orders = > + MEDIA_BUS_CSI2_CPHY_LINE_ORDER_BCA > > + MEDIA_BUS_CSI2_CPHY_LINE_ORDER_ABC>; > > remote-endpoint = <&max96712_out1>; > > }; > > }; > > Using the MEDIA_BUS_CSI2_CPHY_LINE_ORDER_* definitions has a hard > dependency on commit 91a7088096a49eb4 ("media: dt-bindings: Add property > to describe CSI-2 C-PHY line orders") in media/master, hence I cannot > take this patch in renesas-devel until that dependency is resolved. > > However, according to the cover letter, commit 573b4adddbd22baf ("media: > v4l: fwnode: Parse MiPI DisCo for C-PHY line-orders") in media/master > causes a regression in the absence of the line-orders properties > (which I had missed before, unfortunately). > So I think it is best if this patch goes in through the media tree, > which already has the prerequisites and the regression: > Acked-by: Geert Uytterhoeven > > Alternatively, I can: > 1. Cherry-pick commit 91a7088096a49eb4 first, > 2. Replace the MEDIA_BUS_CSI2_CPHY_LINE_ORDER_* definitions by > their numerical values. > > Please let me know if you prefer option 1 or 2. > Thanks! My preference would be for this patch to go thru the media tree with your tags to create the least churn, if Sakari is OK with that ofc. If not I leave it up to Sakari which option is most preferable to him, I'm OK with both alternatives. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kind Regards, Niklas Söderlund