Re: [PATCH v3 0/8] media: renesas: vsp1: Fix v4l2-compliance failures

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

Hi Laurent,

Thanks for your series.

On 2025-07-04 03:18:04 +0300, Laurent Pinchart wrote:
> Hello,
> 
> This series fixes all v4l2-compliance failures in the VSP1 driver. The
> v4l2-compliance log is long, and not that interesting as there's no
> failure. Here's the executive summary, if anyone wants the full log,
> please let me know.
> 
> ----------------------------------------
> root@buildroot ~ # v4l2-compliance -m /dev/media1
> v4l2-compliance 1.31.0-5383, 64 bits, 64-bit time_t
> v4l2-compliance SHA: 58fb1141ca7c 2025-07-03 19:50:58
> 
> Compliance test for vsp1 device /dev/media1:
> 
> Media Driver Info:
>         Driver name      : vsp1
>         Model            : VSP2-BD
>         Serial           :
>         Bus info         : platform:fe960000.vsp
>         Media version    : 6.16.0
>         Hardware revision: 0x01011504 (16848132)
>         Driver version   : 6.16.0
> 
> [...]
> 
> 
> Grand Total for vsp1 device /dev/media1: 751, Succeeded: 751, Failed: 0, Warnings: 0
> ----------------------------------------
> 
> The series has also been tested with the vsp-tests suite, which reported
> no regression.
> 
> Compared to v2, I've fixed a bisection compilation breakage in patch 1/8.

I don't know the VSP internals good enough to provide a R-b, but I had 
read all commits and they look good.

I also tested the series together with the VSPX and the still out of 
tree ISP driver and all works as expected, for that use-case,

Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
> Laurent Pinchart (8):
>   media: renesas: vsp1: Store supported media bus codes in vsp1_entity
>   media: renesas: vsp1: Store size limits in vsp1_entity
>   media: renesas: vsp1: Fix code checks in frame size enumeration
>   media: renesas: vsp1: Fix crop left and top clamping on RPF
>   media: renesas: vsp1: Fix crop width and height clamping on RPF
>   media: renesas: vsp1: Fix RWPF media bus code and frame size
>     enumeration
>   media: renesas: vsp1: Fix format propagation on the BRX
>   media: renesas: vsp1: Implement control events
> 
>  .../media/platform/renesas/vsp1/vsp1_brx.c    |  37 ++---
>  .../media/platform/renesas/vsp1/vsp1_clu.c    |  47 ++-----
>  .../media/platform/renesas/vsp1/vsp1_entity.c | 110 +++++++--------
>  .../media/platform/renesas/vsp1/vsp1_entity.h |  21 +--
>  .../media/platform/renesas/vsp1/vsp1_histo.c  |  27 ++--
>  .../media/platform/renesas/vsp1/vsp1_histo.h  |   2 -
>  .../media/platform/renesas/vsp1/vsp1_hsit.c   |  24 ++--
>  .../media/platform/renesas/vsp1/vsp1_iif.c    |  39 ++----
>  .../media/platform/renesas/vsp1/vsp1_lif.c    |  40 ++----
>  .../media/platform/renesas/vsp1/vsp1_lut.c    |  47 ++-----
>  .../media/platform/renesas/vsp1/vsp1_rpf.c    |   7 +-
>  .../media/platform/renesas/vsp1/vsp1_rwpf.c   | 127 ++++++++++++++----
>  .../media/platform/renesas/vsp1/vsp1_rwpf.h   |   6 +-
>  .../media/platform/renesas/vsp1/vsp1_sru.c    |  63 ++++-----
>  .../media/platform/renesas/vsp1/vsp1_uds.c    |  62 ++++-----
>  .../media/platform/renesas/vsp1/vsp1_uif.c    |  40 ++----
>  .../media/platform/renesas/vsp1/vsp1_wpf.c    |  13 +-
>  17 files changed, 335 insertions(+), 377 deletions(-)
> 
> 
> base-commit: c26e8dcd9d4e86d788c5bf7a5dd0ea70a95ab067
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> 

-- 
Kind Regards,
Niklas Söderlund