linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Pecio" <michal.pecio@gmail.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: linux-usb@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Vinod Koul <vkoul@kernel.org>,
	stable@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] usb: renesas-xhci: Fix External ROM access timeouts
Date: Tue, 29 Jul 2025 12:17:59 +0200	[thread overview]
Message-ID: <20250729121759.0e9df735@foxbook> (raw)
In-Reply-To: <20250727154516.11599-1-marek.vasut+renesas@mailbox.org>

Hi,

On Sun, 27 Jul 2025 17:44:16 +0200, Marek Vasut wrote:
> Increase the External ROM access timeouts to prevent failures during
> programming of External SPI EEPROM chips. The current timeouts are
> too short for some SPI EEPROMs used with uPD720201 controllers.
> 
> The current timeout for Chip Erase in renesas_rom_erase() is 100 ms ,
> the current timeout for Sector Erase issued by the controller before
> Page Program in renesas_fw_download_image() is also 100 ms. Neither
> timeout is sufficient for e.g. the Macronix MX25L5121E or MX25V5126F.

Out of curiosity, who uses this ROM update functionality and why?

It seems weird to write nonvolatile memories in a PCI probe routine.
Boards or PCIe cards fitted with ROMs are programmed with working
firmware at the factory and there ought to be no need to touch that.

And if you want to update this FW, dropping a file in /lib/firmware/
and loading a kernel module is not the usual (or convenient) UI...

Regards,
Michal


  parent reply	other threads:[~2025-07-29 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 15:44 [PATCH] usb: renesas-xhci: Fix External ROM access timeouts Marek Vasut
2025-07-28  4:18 ` Greg Kroah-Hartman
2025-07-29  3:09   ` Marek Vasut
2025-07-29  5:03     ` Greg Kroah-Hartman
2025-07-29  7:11       ` Geert Uytterhoeven
2025-07-29  7:55         ` Greg Kroah-Hartman
2025-07-29 10:17 ` Michał Pecio [this message]
2025-08-02 22:30   ` Marek Vasut
2025-07-29 15:20 ` Mathias Nyman
2025-08-02 22:54   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729121759.0e9df735@foxbook \
    --to=michal.pecio@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=mathias.nyman@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).