From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2882920AF87; Sat, 2 Aug 2025 09:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754126679; cv=none; b=Dvs4SvZTiu1EIx43xZ7cFWwP7ykYbM/1VU7xaWyL1N0Yw3YsMsOuaQ+HJWEjGP9ase6tS91Xx6zhK9k9Au+oTsc/YkVGLkxyJ/TP39CtOCKZpH3lzI9qxbz4kdDUyIpdUoEwEGj0RdIXV34ZX27pRGJJEsL4D+qPr73I08OYwwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754126679; c=relaxed/simple; bh=6F3PmnRdTsR6MP0pAkheGJaZIteib7h3Mt38QOL4+ks=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MHD7Sz2Tuy8cXRbrITLkdwAyo+dHXVzoKNS7QCJV8G0fB1Y8XPkt4FEyNPbLZjv3SUwlQc5Ik99yo67GtmgPaPvTVtSdteTIZyYOxbXHhzjDNbdzq0HWfoUB4ZagAFgpBS3aD8UUIHor8dT31KzJlzQ9hYkcR2MMdsljhQJtIqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=rAFxA493; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rAFxA493" Received: from [192.168.0.172] (mob-5-90-138-121.net.vodafone.it [5.90.138.121]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BCA411741; Sat, 2 Aug 2025 11:23:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1754126630; bh=6F3PmnRdTsR6MP0pAkheGJaZIteib7h3Mt38QOL4+ks=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rAFxA493SWAD9TKKi/8m6Hv+f3yVH6PRa9hRM3hBnrJQOoaSrfgP62Rrltl40evok C5qla7DhplXPFGaijSw8DaDg6nxNxBBJidrW2Jc5A2cAuKm1xh4hu9gekA4a35DdgQ rE2UrWTUAmvbnSBwN7+1sWr/1aDIf4+mcroDG+YM= From: Jacopo Mondi Date: Sat, 02 Aug 2025 11:22:29 +0200 Subject: [PATCH 07/65] media: staging: most: Store v4l2_fh pointer in file->private_data Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250802-media-private-data-v1-7-eb140ddd6a9d@ideasonboard.com> References: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> In-Reply-To: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> To: Mauro Carvalho Chehab , Devarsh Thakkar , Benoit Parrot , Hans Verkuil , Mike Isely , Laurent Pinchart , Hans de Goede , Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , Alex Shi , Yanteng Si , Dongliang Mu , Jonathan Corbet , Tomasz Figa , Marek Szyprowski , Andy Walls , Michael Tretter , Pengutronix Kernel Team , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Kieran Bingham , Michal Simek , Ming Qian , Zhou Peng , Xavier Roumegue , Philipp Zabel , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Sylwester Nawrocki , Jernej Skrabec , Chen-Yu Tsai , Samuel Holland , Daniel Almeida , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Nas Chung , Jackson Lee , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Geert Uytterhoeven , Magnus Damm , Mikhail Ulyanov , Jacob Chen , Ezequiel Garcia , Heiko Stuebner , Detlev Casanova , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , =?utf-8?q?=C5=81ukasz_Stelmach?= , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Hugues Fruchet , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Nicolas Dufresne , Benjamin Gaignard , Steve Longerbeam , Maxime Ripard , Paul Kocialkowski , =?utf-8?q?Niklas_S=C3=B6derlund?= , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Corentin Labbe , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Stanislaw Gruszka Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, mjpeg-users@lists.sourceforge.net, Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2287; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=d1NV4J7Giad62JgBsrW5PwS1cT7NJmAZ57UHAI1qwVg=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBojdj4d2z3dXIt37s+JMRVX5xja57etKpuYf7wo w1WB8WrjYGJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaI3Y+AAKCRByNAaPFqFW PKm9D/9cOtEDkLOKZwjwKkZQThkzdJmTDjhOz4PDCmlo2gyCGRkvtl9sCDXyx6IFzek1RzaMV4M ojKA+L06VoolHAjP9McH2iYSVvbx9IGkWX6g2bQaw3b4RPQJt/TaMpqmMxBrCs0OlCQhqhOnLTo lmwiFYLW9XqtmrQcOVEHPuEKna2X1pKfKX73eOm/WlDOVbksbN6uMkOrk/9sHkshZS3imopwIoX OywTU1stICqKyghDw7nC/v7lllKShDBaOkrbkIfS+XlLpWdPwv50HF/2WzOn25+D36ttakcZBx6 Cjyskopw7Td+2t/zKTZcYtj28/U0xC9N1OOwgTwVwyhQXKRzdd/5gOnKqBYifJSQhATNhCwY85f CWb9xknx3/Y5pjngkIj0YVOKy2DD9Bbocipp9rSF7BbQvOZhnEZZFQyFTd6zmLoAvAKXZJU6R/A W2jjCmzX7MNuVSa9j/F923fad/g2S9VaJmrlYL4AeUxKa1VhKCwhNlyFHa2/KzDgkPh7AWQ99Xa pMofXhpiIAdlCkX7rNpdqkiIRlytrnbhqnAhUFQtMpZohW6hBxc1ECBKdMaayvVssNdvDhuQTsn PSFFLv/XcnpqSj64xb73UcbzR2357sniQCZsr+79OOKiwECemqEy9EDBOhL/zSH0EenrSWHKifx 8W0FfhQ7Q2FtIew== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B From: Laurent Pinchart Most V4L2 drivers store the v4l2_fh pointer in file->private_data. The most driver instead stores the pointer to the driver-specific structure that embeds the v4l2_fh. Switch to storing the v4l2_fh pointer itself to standardize behaviour across drivers. This also prepares for future refactoring that depends on v4l2_fh being stored in private_data. Signed-off-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/staging/most/video/video.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 2b3cdb1ce1404cd13655c780f1215c364ce1a70f..bce7ffeac8fe50d3442f4993ae49ab5fc96ec3cd 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -52,6 +52,11 @@ struct comp_fh { u32 offs; }; +static inline struct comp_fh *to_comp_fh(struct file *filp) +{ + return container_of(filp->private_data, struct comp_fh, fh); +} + static LIST_HEAD(video_devices); static DEFINE_SPINLOCK(list_lock); @@ -91,7 +96,7 @@ static int comp_vdev_open(struct file *filp) fh->mdev = mdev; v4l2_fh_init(&fh->fh, vdev); - filp->private_data = fh; + filp->private_data = &fh->fh; v4l2_fh_add(&fh->fh); @@ -115,7 +120,7 @@ static int comp_vdev_open(struct file *filp) static int comp_vdev_close(struct file *filp) { - struct comp_fh *fh = filp->private_data; + struct comp_fh *fh = to_comp_fh(filp); struct most_video_dev *mdev = fh->mdev; struct mbo *mbo, *tmp; @@ -151,7 +156,7 @@ static int comp_vdev_close(struct file *filp) static ssize_t comp_vdev_read(struct file *filp, char __user *buf, size_t count, loff_t *pos) { - struct comp_fh *fh = filp->private_data; + struct comp_fh *fh = to_comp_fh(filp); struct most_video_dev *mdev = fh->mdev; int ret = 0; @@ -200,7 +205,7 @@ static ssize_t comp_vdev_read(struct file *filp, char __user *buf, static __poll_t comp_vdev_poll(struct file *filp, poll_table *wait) { - struct comp_fh *fh = filp->private_data; + struct comp_fh *fh = to_comp_fh(filp); struct most_video_dev *mdev = fh->mdev; __poll_t mask = 0; -- 2.49.0