[PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization

[PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization

[Niklas Cassel]

Hello all,

struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.

Series is based on pci/next.

Feel free to squash to a single commit if that is preferable.

Kind regards,
Niklas


Niklas Cassel (13):
  PCI: cadence-ep: Drop superfluous pci_epc_features initialization
  PCI: rcar-ep: Drop superfluous pci_epc_features initialization
  PCI: rockchip-ep: Drop superfluous pci_epc_features initialization
  PCI: dra7xx: Drop superfluous pci_epc_features initialization
  PCI: imx6: Drop superfluous pci_epc_features initialization
  PCI: keystone: Drop superfluous pci_epc_features initialization
  PCI: artpec6: Drop superfluous pci_epc_features initialization
  PCI: designware-plat: Drop superfluous pci_epc_features initialization
  PCI: dw-rockchip: Drop superfluous pci_epc_features initialization
  PCI: keembay: Drop superfluous pci_epc_features initialization
  PCI: qcom-ep: Drop superfluous pci_epc_features initialization
  PCI: rcar-gen4: Drop superfluous pci_epc_features initialization
  PCI: tegra194: Drop superfluous pci_epc_features initialization

 drivers/pci/controller/cadence/pcie-cadence-ep.c  | 2 --
 drivers/pci/controller/dwc/pci-dra7xx.c           | 1 -
 drivers/pci/controller/dwc/pci-imx6.c             | 4 ----
 drivers/pci/controller/dwc/pci-keystone.c         | 1 -
 drivers/pci/controller/dwc/pcie-artpec6.c         | 2 --
 drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
 drivers/pci/controller/dwc/pcie-dw-rockchip.c     | 2 --
 drivers/pci/controller/dwc/pcie-keembay.c         | 1 -
 drivers/pci/controller/dwc/pcie-qcom-ep.c         | 1 -
 drivers/pci/controller/dwc/pcie-rcar-gen4.c       | 2 --
 drivers/pci/controller/dwc/pcie-tegra194.c        | 2 --
 drivers/pci/controller/pcie-rcar-ep.c             | 2 --
 drivers/pci/controller/pcie-rockchip-ep.c         | 1 -
 13 files changed, 22 deletions(-)

-- 
2.50.1

[PATCH 02/13] PCI: rcar-ep: Drop superfluous pci_epc_features initialization

[Niklas Cassel]

struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/pci/controller/pcie-rcar-ep.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
index a8a966844cf3..657875ef4657 100644
--- a/drivers/pci/controller/pcie-rcar-ep.c
+++ b/drivers/pci/controller/pcie-rcar-ep.c
@@ -436,9 +436,7 @@ static void rcar_pcie_ep_stop(struct pci_epc *epc)
 }
 
 static const struct pci_epc_features rcar_pcie_epc_features = {
-	.linkup_notifier = false,
 	.msi_capable = true,
-	.msix_capable = false,
 	/* use 64-bit BARs so mark BAR[1,3,5] as reserved */
 	.bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = 128,
 			.only_64bit = true, },
-- 
2.50.1

[PATCH 12/13] PCI: rcar-gen4: Drop superfluous pci_epc_features initialization

[Niklas Cassel]

struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
index 366e21bffcbe..d787f2a364d5 100644
--- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
+++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
@@ -398,9 +398,7 @@ static int rcar_gen4_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
 }
 
 static const struct pci_epc_features rcar_gen4_pcie_epc_features = {
-	.linkup_notifier = false,
 	.msi_capable = true,
-	.msix_capable = false,
 	.bar[BAR_1] = { .type = BAR_RESERVED, },
 	.bar[BAR_3] = { .type = BAR_RESERVED, },
 	.bar[BAR_4] = { .type = BAR_FIXED, .fixed_size = 256 },
-- 
2.50.1

Re: [PATCH 02/13] PCI: rcar-ep: Drop superfluous pci_epc_features initialization

[Geert Uytterhoeven]

On Thu, 14 Aug 2025 at 17:21, Niklas Cassel <cassel@kernel.org> wrote:
> struct pci_epc_features has static storage duration, so all struct members
> are zero initialized implicitly. Thus, remove explicit zero initialization
> of struct members.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 12/13] PCI: rcar-gen4: Drop superfluous pci_epc_features initialization

[Geert Uytterhoeven]

On Thu, 14 Aug 2025 at 17:22, Niklas Cassel <cassel@kernel.org> wrote:
> struct pci_epc_features has static storage duration, so all struct members
> are zero initialized implicitly. Thus, remove explicit zero initialization
> of struct members.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization

[Bjorn Helgaas]

On Thu, Aug 14, 2025 at 05:21:19PM +0200, Niklas Cassel wrote:
> Hello all,
> 
> struct pci_epc_features has static storage duration, so all struct members
> are zero initialized implicitly. Thus, remove explicit zero initialization
> of struct members.
> 
> Series is based on pci/next.
> 
> Feel free to squash to a single commit if that is preferable.
> 
> Kind regards,
> Niklas
> 
> 
> Niklas Cassel (13):
>   PCI: cadence-ep: Drop superfluous pci_epc_features initialization
>   PCI: rcar-ep: Drop superfluous pci_epc_features initialization
>   PCI: rockchip-ep: Drop superfluous pci_epc_features initialization
>   PCI: dra7xx: Drop superfluous pci_epc_features initialization
>   PCI: imx6: Drop superfluous pci_epc_features initialization
>   PCI: keystone: Drop superfluous pci_epc_features initialization
>   PCI: artpec6: Drop superfluous pci_epc_features initialization
>   PCI: designware-plat: Drop superfluous pci_epc_features initialization
>   PCI: dw-rockchip: Drop superfluous pci_epc_features initialization
>   PCI: keembay: Drop superfluous pci_epc_features initialization
>   PCI: qcom-ep: Drop superfluous pci_epc_features initialization
>   PCI: rcar-gen4: Drop superfluous pci_epc_features initialization
>   PCI: tegra194: Drop superfluous pci_epc_features initialization
> 
>  drivers/pci/controller/cadence/pcie-cadence-ep.c  | 2 --
>  drivers/pci/controller/dwc/pci-dra7xx.c           | 1 -
>  drivers/pci/controller/dwc/pci-imx6.c             | 4 ----
>  drivers/pci/controller/dwc/pci-keystone.c         | 1 -
>  drivers/pci/controller/dwc/pcie-artpec6.c         | 2 --
>  drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c     | 2 --
>  drivers/pci/controller/dwc/pcie-keembay.c         | 1 -
>  drivers/pci/controller/dwc/pcie-qcom-ep.c         | 1 -
>  drivers/pci/controller/dwc/pcie-rcar-gen4.c       | 2 --
>  drivers/pci/controller/dwc/pcie-tegra194.c        | 2 --
>  drivers/pci/controller/pcie-rcar-ep.c             | 2 --
>  drivers/pci/controller/pcie-rockchip-ep.c         | 1 -
>  13 files changed, 22 deletions(-)

Squashed into one, added "remove explicit zero initialization for
features that are *not* supported so we don't have to touch existing
drivers as new features are added" to commit log, and applied to
pci/endpoint for v6.18, thanks, Niklas!