From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B05340DAE for ; Tue, 19 Aug 2025 20:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635594; cv=none; b=P3Ix1HGy46bvBUg5KrhNvkpKM8+jM7Ne+LhvpvhmQTtSOgRd1uV46k+C/WEGPut1j9LheflEEsGykCJBvgursTf9AufdwhvFrGdbXs8q0GnkAfFvvi57xl+xjiINU2vqe6J7fGyB5i6sF+RQoYeCbrRTG5xoNg6GSB3QqeeQnQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755635594; c=relaxed/simple; bh=n7xaHZSSROB+2XdVsucGDeHL2qDsHnv9brWl2LaC/6Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iAhxqMQonuJ6KcZm80T4Rs8PmKpDGBlbjK+UHWqvfrGy7kYopmrWoRCPeIYQXSCbmtiFODFWC4XBIcdcXk4N8th3zOouDGBJFNgLQm99kcgffXYAmhx/VCs4L298UpDkSfaYw6rcRnVIP3cmK7Vlzbos6Am2juFWSIonrVdayZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S8Uhmr/4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S8Uhmr/4" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57JHmfPB030294 for ; Tue, 19 Aug 2025 20:33:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uae42TaI8vGi2qGQ8bwNSeWnG/c2PiftWqaI8l7bbt8=; b=S8Uhmr/4O+nSPYIm 2zKbhC/oDjV9DkZ26zlb6qdRRPz5Rnu4ww2ej5v0TmDFmkdYXv8TFVeTP/bGwxsb 4ZxQ/2im9UB6JRhBSPPadrP6c6xKYOU/sHEkIlTyb59nZdRsVRfqUKazW2GxnS+H aaRQM4t55EbBdmsQ47OzwhMocAXF0XDTJo+mbWRGecA/e6GR7IKVMmJ2s4Jbj4fl ZK5O0LX5cytxx88P+iIVnB8iDHNFRFHTIUma/cchElwTH8ASfdFxrYbMrbaas43I WepbyRcoss2ENw0vXLUxZn+tJtkDSdBp0OkS0+lQaOo+uw1esXpqN1Z1fDiJrdB/ Lbw0Yg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48kyunx4mj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 20:33:11 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-70a88dd0193so130483466d6.0 for ; Tue, 19 Aug 2025 13:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755635591; x=1756240391; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uae42TaI8vGi2qGQ8bwNSeWnG/c2PiftWqaI8l7bbt8=; b=DSPtO7g5UQb31TbbiO9MfYaYkplFhIlX/j9qI03z7Uco9iuSxaUuNN3WaACZ+r8hwG hLzRE2lKPL2AuUY9kC+3Dp4x7vbqWvTAT0YnzYc1AjfSTGN/qRi/JZpos+nKyRJWMRY+ 97YcGHPrlacPI04iDkCgnJH5I017mUjqsiF0XhsPPZIyVBBX67wSQOUZ2omHP+4XYlEK 47jEmdENnlA0eiIX8B4hLdchx+SuyTvxQ3ATkgCV8OEXZQ9CDgnPVm32ZPI7UhjZva1o T+O/PY77+vjZg1FkixMHRNQMUHZxLAqBtq1AYot5/OW1YIK8ukb4K8PhlXHU6MA0WKyJ Fefw== X-Forwarded-Encrypted: i=1; AJvYcCUbyeAQB7868rQecMqFoTC2COCKEuT+ZnhakjBH4TP4zUXZli24fNn2AAcz6JG6ICOlLmJbH8+hu6LWWzdM5JrOdw==@vger.kernel.org X-Gm-Message-State: AOJu0YzKueweduWwin+P/4WpIQa3RFJFvsb481U/Z2l2dkvKoYZKdK4O h6bvHda1WpT9Qln7/EZ0mavRPZ2DvlaTYwsHkByX6fUQCXqbLwgDWOmdyJzyGJPOSEhn6xSVrm4 moN4Q+a4CURuOFrmakHx1U+wpLHXNBHs0PEAV/RGN1rNcpIm9EMv9f/SkRgLk3r8WWl+i0V5FzA == X-Gm-Gg: ASbGncs+X9otIcccFzvOafBCzSp8jIVqLavKZFbI2bAdx7KAMg7nMi8+ze4uioy6NtJ ddkFMdaxEHdRIES0Liq9zbQ1cCBFU368jyBrb1n3JYHINH/MS0T77h6qfhwWq81kG9JmqSsx6pG n8pKiJlY998RvTof2Me0Uuj8KO+Wp1zMmXf5D4z7bJu8qv8O3P7TWk8dkdDGiH+ouK2qANStj4Q vIk3X5hbXvBnHCkHrEeEGyr7RY4qSWl/WK9MzI/pd5hsUuXGMOH0+uQdEH0+nTV5Gb+RM9prkqe mMVqqjQ9dnJLpGapllww/MurXPrKUrk/mqESrWUP+LnZ35eSpG1i2XNU6DaW9nbXPDogetE+nYX 3vk5oY8hiiqcWJKfS0Zv2inAtV8+UzkM46q7xOmfN8CrzFJVcrWun X-Received: by 2002:a05:6214:40e:b0:707:4aa0:2f1 with SMTP id 6a1803df08f44-70d76fb03e1mr4791936d6.16.1755635590873; Tue, 19 Aug 2025 13:33:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjMUMGSvjeQdbIF0CDnT7P91YufaBD6waHQI6sRs/n+ZhEnj+eKGwawlgjU4rExarcr2ll3Q== X-Received: by 2002:a05:6214:40e:b0:707:4aa0:2f1 with SMTP id 6a1803df08f44-70d76fb03e1mr4791326d6.16.1755635590143; Tue, 19 Aug 2025 13:33:10 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55cef351806sm2212969e87.13.2025.08.19.13.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 13:33:08 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 19 Aug 2025 23:32:58 +0300 Subject: [PATCH v3 4/8] drm/msm/dpu: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250819-wb-drop-encoder-v3-4-b48a6af7903b@oss.qualcomm.com> References: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> In-Reply-To: <20250819-wb-drop-encoder-v3-0-b48a6af7903b@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1988; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=n7xaHZSSROB+2XdVsucGDeHL2qDsHnv9brWl2LaC/6Y=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBopN98gnguR5E87tGamvaP6AjPWdsyN4w0BBcCn Y3DFYviK+CJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaKTffAAKCRCLPIo+Aiko 1cIrCACZlMfXC1ZcXwkARC5jlvs99j4JLrzEnSVtPScea3jfX6Xnp5Sy3egmpoSPlOFc5GNZuv7 tqe8otrW1rgAZmoYKaWQPBtK/LzQYdu3u91oc3Ox3LhGbAIyK5c7Thl64ufZc5/XlENC8WsV34V q1Xb0pEDgNJdOAnN0d5l63dDxaacI912igs103k+ehliPAInW7DUdnmfFXdbnIQ7H45O5AoSTOM d7yhDfGWM68rDdlB9nvgMh/Tgra+l/algQswzhz+QQtwewmL8JTifw1PjO2q3eIAGUeon50Ldr8 2F5d8cwAbCkKPqKEQsVJgrO+38orTXv/L+6y81c0EHhHs1E4 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: jO0uAFzGeYC3nKiqZMdcbBXZbrHvWIwA X-Authority-Analysis: v=2.4 cv=N6UpF39B c=1 sm=1 tr=0 ts=68a4df87 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=UqIHtJT1QCIVCAY24KsA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE4MDA3MSBTYWx0ZWRfX/Gsnx/BVMme3 UlnOPhvML+d2Tdtn7S5OnefouBkzBA07QkOPfiqgurz8xpN6DePhWM66kVjgsa0k0zl/Wo9RIr+ HpRXSrzmshL58/mfBy8g8WfyxBjAV8TmEZtHum3BD3LuHdcNDNn/aAec3bQPKJRYs+Ce6cgnzj8 1iDk6Vo/s5pO038ma276bN7LItGS00vDhKUKdXqmONhh1QRDeR696MCsM/06f2QAlWjNqMB0ons knEqm30SpnrBC3zghIjn95R99qHbC5VnOPIhEzSxAA88GWuxIGNkayTxkbpvFfllqUzD2kX2M4p UhKQpQN61EK5Hp9W1oeVO+BeFbkTdZHAE1Hnu9qea4ZKVCNPjEAH7jcuKSb4OguYzm12TAIwVNY JSBGGoul X-Proofpoint-ORIG-GUID: jO0uAFzGeYC3nKiqZMdcbBXZbrHvWIwA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_03,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508180071 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Reviewed-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c index 8ff496082902b1ee713e806140f39b4730ed256a..cd73468e369a93c50303db2a7d4499bcb17be5d1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -80,7 +80,6 @@ static int dpu_wb_conn_atomic_check(struct drm_connector *connector, static const struct drm_connector_funcs dpu_wb_conn_funcs = { .reset = drm_atomic_helper_connector_reset, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = drm_connector_cleanup, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; @@ -131,12 +130,9 @@ int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc, drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_funcs); - /* DPU initializes the encoder and sets it up completely for writeback - * cases and hence should use the new API drm_writeback_connector_init_with_encoder - * to initialize the writeback connector - */ - rc = drm_writeback_connector_init_with_encoder(dev, &dpu_wb_conn->base, enc, - &dpu_wb_conn_funcs, format_list, num_formats); + rc = drmm_writeback_connector_init(dev, &dpu_wb_conn->base, + &dpu_wb_conn_funcs, enc, + format_list, num_formats); if (!rc) dpu_wb_conn->wb_enc = enc; -- 2.47.2