[PATCH] ARM: dts: renesas: gose: remove superfluous port property

[PATCH] ARM: dts: renesas: gose: remove superfluous port property

[Wolfram Sang]

'bus-width' is defined for the corresponding vin input port already. No
need to declare it in the output port again. Fixes:

arch/arm/boot/dts/renesas/r8a7793-gose.dtb: composite-in@20 (adi,adv7180cp): ports:port@3:endpoint: Unevaluated properties are not allowed ('bus-width' was unexpected)

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r8a7793-gose.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/renesas/r8a7793-gose.dts b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
index 45b267ec2679..5c6928c941ac 100644
--- a/arch/arm/boot/dts/renesas/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
@@ -373,7 +373,6 @@ adv7180_in: endpoint {
 				port@3 {
 					reg = <3>;
 					adv7180_out: endpoint {
-						bus-width = <8>;
 						remote-endpoint = <&vin1ep>;
 					};
 				};
-- 
2.47.2

Re: [PATCH] ARM: dts: renesas: gose: remove superfluous port property

[Geert Uytterhoeven]

On Mon, 29 Sept 2025 at 11:36, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> 'bus-width' is defined for the corresponding vin input port already. No
> need to declare it in the output port again. Fixes:
>
> arch/arm/boot/dts/renesas/r8a7793-gose.dtb: composite-in@20 (adi,adv7180cp): ports:port@3:endpoint: Unevaluated properties are not allowed ('bus-width' was unexpected)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.19.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: dts: renesas: gose: remove superfluous port property

[Geert Uytterhoeven]

On Mon, 29 Sept 2025 at 15:25, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, 29 Sept 2025 at 11:36, Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > 'bus-width' is defined for the corresponding vin input port already. No
> > need to declare it in the output port again. Fixes:
> >
> > arch/arm/boot/dts/renesas/r8a7793-gose.dtb: composite-in@20 (adi,adv7180cp): ports:port@3:endpoint: Unevaluated properties are not allowed ('bus-width' was unexpected)

Adding

    from schema $id: http://devicetree.org/schemas/media/i2c/adi,adv7180.yaml#

so it's a little bit easier to find out what to pass to DT_SCHEMA_FILES=
for a reduced check.

> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.19.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: dts: renesas: gose: remove superfluous port property

[Geert Uytterhoeven]

Hi Wolfram,

CC Niklas

On Mon, 29 Sept 2025 at 11:36, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> 'bus-width' is defined for the corresponding vin input port already. No
> need to declare it in the output port again. Fixes:
>
> arch/arm/boot/dts/renesas/r8a7793-gose.dtb: composite-in@20 (adi,adv7180cp): ports:port@3:endpoint: Unevaluated properties are not allowed ('bus-width' was unexpected)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> @@ -373,7 +373,6 @@ adv7180_in: endpoint {
>                                 port@3 {
>                                         reg = <3>;
>                                         adv7180_out: endpoint {
> -                                               bus-width = <8>;
>                                                 remote-endpoint = <&vin1ep>;
>                                         };
>                                 };

I think r8a7791-koelsch.dts has the same issue, but currently it is
not flagged by dtbs_check because adi,adv7180 uses slightly different
and less modern DT bindings than adi,adv7180cp.
However, according to the schematics both Koelsch and Gose use
ADV7180WBCP32Z, so r8a7791-koelsch.dts should use adi,adv7180cp, too?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: dts: renesas: gose: remove superfluous port property

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]


> I think r8a7791-koelsch.dts has the same issue, but currently it is
> not flagged by dtbs_check because adi,adv7180 uses slightly different
> and less modern DT bindings than adi,adv7180cp.
> However, according to the schematics both Koelsch and Gose use
> ADV7180WBCP32Z, so r8a7791-koelsch.dts should use adi,adv7180cp, too?

Well, Niklas has a Koelsch and would probably be happy to test his new
Gen2-enabled CI with this change? :D


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] ARM: dts: renesas: gose: remove superfluous port property

[Niklas Söderlund]

On 2025-09-29 23:14:51 +0200, Wolfram Sang wrote:
> 
> > I think r8a7791-koelsch.dts has the same issue, but currently it is
> > not flagged by dtbs_check because adi,adv7180 uses slightly different
> > and less modern DT bindings than adi,adv7180cp.
> > However, according to the schematics both Koelsch and Gose use
> > ADV7180WBCP32Z, so r8a7791-koelsch.dts should use adi,adv7180cp, too?
> 
> Well, Niklas has a Koelsch and would probably be happy to test his new
> Gen2-enabled CI with this change? :D

Tested, CI pass, sent. Thanks for the original work and the ping, much 
nicer!

-- 
Kind Regards,
Niklas Söderlund