From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D286B3093AB for ; Mon, 13 Oct 2025 14:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364920; cv=none; b=bRX8/7pXtEHt1A3OsmWNeCg3ThaukCJBVlchwFQbXW4vrwIEvPwS6mZWU3DJ06A/jX5D1FFGcanyXlqfR1wJ5746ZHnNUERngQIlJMG6kVaBAVx3v/QD/wsWswtLMmEcdZ6yfnIVgk6iE+HUhB5Nn2icbIzsYRJ4SHTWcev4If4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364920; c=relaxed/simple; bh=1KGLnwkNkXZu6CtEdNPModZR1Vc28L95VShr6d6uVXE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TobGhWoXNa1jOChKQSX7QkZbsND2cEa+K2Ji5Dn2/tSv7jwZOPEcqM231FnbSl5usU+Gy/M7Mlck47ACx51J6ztFTbef0iHOHVVGlLhv7qPo8+oiAS0hjOp3YMMyoJVUQRPBZ/ygCYgsjANOe+95IewKWGvnwYqPEW+fSNsT9Ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KBkCTGve; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KBkCTGve" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-57da66e0dc9so4294623e87.0 for ; Mon, 13 Oct 2025 07:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364902; x=1760969702; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XTfgrP773mTzuIwpFbkRpkdwa1sJQvDkaUU5vsQzRTQ=; b=KBkCTGveZFTbNnm9yL8Hva2hAVSadFJTVH/gHAix+vxv5DRP/QYgtuQhpzVdIOJXfX ASvboVONdg9jucIO1VpkVrKI2Q/4V6STrYUGqayCJSC3eHHhqufyJ5kHA94a+zNwwTk1 nIZp3GiISQDgZHP8/+k9u/49ZquBxlesRB8bo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364902; x=1760969702; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XTfgrP773mTzuIwpFbkRpkdwa1sJQvDkaUU5vsQzRTQ=; b=SfWgNDLrzVr0a6nbIlXGn/ehmrnWyxX239kNjqwkOlNnGCXyVVuvPQ63l6HHfLUTpL VY0Qmx0botqbfG/OJ9K2vZb50dJugEpr+CB7AO+D54+zrnLMaGWr/WBgPiwN9sGvyRXm HUAlnFOrf+OB+BvHSdAjWUiXHF7oXjixrHWBns/XV/v/K6nmN7D55S0VIoiZZhvTExZ1 qgF832dHmY1cmpkdMDO4M49+xYFAX+TBi4CPXr/5rHlgdgLzamLyzWjpqOA6Gnq9zDiP OSSu7K1g0unZhmvXl45f6okpeKKbl4EMVrduuQaAvGbjgbXjnrceWLnHenQohMmkuBuc S2RA== X-Forwarded-Encrypted: i=1; AJvYcCUnG5WEhZwg6cewD8DHtQ64acofJvrYaJJmXr0iDzzygH3Ui9nVd1MbOqlo0lfvHIq4qbGTueywgwcNK6P4lI2Pkw==@vger.kernel.org X-Gm-Message-State: AOJu0YzQOyZggWjwSciZGvCcssfk2O1cVa+NrFeDmvWmFr/vi6fFWpiT r6hyV/wPylyObaIPCuylI0TjxDmGRjXTdZTnII5zDAGzBXFXVg6U+u/5WevfgJBjvg== X-Gm-Gg: ASbGncubBA8TIBk/udwHcFGZb2yfdzAyoRekLfLM55BdZr5XaiZEvb0DmIiXYNV1AFp icmXFBhYb3vB+aHVCvzYjK+9Pfo9LgWM70KuPQdEwz+HRJ8xJZctQwR7+FXlu3WGNRRhvHzt0f2 4pO37fWYZ7pj9Wdc50EwH/Ws8ZKGQ4TMrqiAyICEXN6X5IXWDgvc7wF1MJCB9694h1MP8aM5d/z Xqb4uvoR8XRL4EUouoLLn4c0kybbP8H2PCId4PFlZie2/Oh0AEZfHRd9qX5/4iwcf5RgR7tvDX3 /q6rfce5Vb1z4kjw/RuiuBOA7vrnfxftENT3MAUXK1Lvuo0j50fNFm/iWqXkAM3qw43FvGdN5+v K8nFyOkQ8SAG7RTRDREenzj5Br+XhajtkEkdsXMJJx5rhAqAlFiskeSES7Cdd3kdRSsuHoV/tXX 6fy8z5eW9Gg4GS0M1KSudzColFEK5w X-Google-Smtp-Source: AGHT+IEmYSyu4nHTtG8vRgmb2LccUUeX39k0JKnrkMfDo77UUQwM9CrYH1frfefAQcn5JPDuzUf+OA== X-Received: by 2002:a05:6512:104b:b0:58b:394:fd4c with SMTP id 2adb3069b0e04-5906dd6fb89mr6060927e87.33.1760364902483; Mon, 13 Oct 2025 07:15:02 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:15:02 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:15:02 +0000 Subject: [PATCH 22/32] media: ipu3-cio2: Use %pe format specifier Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-22-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./pci/intel/ipu3/ipu3-cio2.c:318:19-26: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index a87f105beb5e267fd450b8a36ef9b0e0ecafc598..986b9afd7cb5b6a07c796b4333f93d427a8c4fbe 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -314,8 +314,8 @@ static int cio2_csi2_calc_timing(struct cio2_device *cio2, struct cio2_queue *q, src_pad = media_entity_remote_source_pad_unique(&q->subdev.entity); if (IS_ERR(src_pad)) { - dev_err(dev, "can't get source pad of %s (%ld)\n", - q->subdev.name, PTR_ERR(src_pad)); + dev_err(dev, "can't get source pad of %s (%pe)\n", + q->subdev.name, src_pad); return PTR_ERR(src_pad); } -- 2.51.0.760.g7b8bcc2412-goog