linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ricardo Ribalda <ribalda@chromium.org>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hans Verkuil" <hverkuil@kernel.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Krzysztof Hałasa" <khalasa@piap.pl>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"Leon Luo" <leonl@leopardimaging.com>,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
	"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Julien Massot" <julien.massot@collabora.com>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
	"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
	"Yong Zhi" <yong.zhi@intel.com>,
	"Bingbu Cao" <bingbu.cao@intel.com>,
	"Tianshu Qiu" <tian.shu.qiu@intel.com>,
	"Tiffany Lin" <tiffany.lin@mediatek.com>,
	"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
	"Yunfei Dong" <yunfei.dong@mediatek.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Rui Miguel Silva" <rmfrfs@gmail.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Martin Kepplinger" <martink@posteo.de>,
	"Purism Kernel Team" <kernel@puri.sm>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Dafna Hirschfeld" <dafna@fastmail.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Yemike Abhilash Chandra" <y-abhilashchandra@ti.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org, imx@lists.linux.dev,
	 linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	 linux-samsung-soc@vger.kernel.org,
	linux-staging@lists.linux.dev,
	 Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 28/32] media: rkisp1: Use %pe format specifier
Date: Mon, 13 Oct 2025 14:15:08 +0000	[thread overview]
Message-ID: <20251013-ptr_err-v1-28-2c5efbd82952@chromium.org> (raw)
In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org>

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/rockchip/rkisp1/rkisp1-isp.c:940:3-10: WARNING: Consider using %pe to print PTR_ERR()
./platform/rockchip/rkisp1/rkisp1-csi.c:372:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c | 4 ++--
 drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
index 841e58c20f7fcb484643138627413425a049d1fa..ddc6182f3e4bdacdd1962c86f6259334b16aa505 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
@@ -368,8 +368,8 @@ static int rkisp1_csi_s_stream(struct v4l2_subdev *sd, int enable)
 
 	source_pad = media_entity_remote_source_pad_unique(&sd->entity);
 	if (IS_ERR(source_pad)) {
-		dev_dbg(rkisp1->dev, "Failed to get source for CSI: %ld\n",
-			PTR_ERR(source_pad));
+		dev_dbg(rkisp1->dev, "Failed to get source for CSI: %pe\n",
+			source_pad);
 		return -EPIPE;
 	}
 
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
index 8c29a1c9309a846152d212dcb50b7bf991d4f422..147d33eb6ee0d975b257c5df2997b811ba3a62e1 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
@@ -936,8 +936,8 @@ static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable)
 	sink_pad = &isp->pads[RKISP1_ISP_PAD_SINK_VIDEO];
 	source_pad = media_pad_remote_pad_unique(sink_pad);
 	if (IS_ERR(source_pad)) {
-		dev_dbg(rkisp1->dev, "Failed to get source for ISP: %ld\n",
-			PTR_ERR(source_pad));
+		dev_dbg(rkisp1->dev, "Failed to get source for ISP: %pe\n",
+			source_pad);
 		return -EPIPE;
 	}
 

-- 
2.51.0.760.g7b8bcc2412-goog


  parent reply	other threads:[~2025-10-13 14:15 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 14:14 [PATCH 00/32] media: Use %pe format specifier Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 01/32] Input: cyttsp5 - " Ricardo Ribalda
2025-10-13 15:35   ` Frank Li
2025-10-13 15:50     ` Ricardo Ribalda
2025-10-17  5:18   ` Dmitry Torokhov
2025-10-13 14:14 ` [PATCH 02/32] media: dvbdev: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 03/32] media: mn88443x: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 04/32] media: adv7842: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 05/32] media: ar0521: " Ricardo Ribalda
2025-10-14  4:24   ` Krzysztof Hałasa
2025-10-13 14:14 ` [PATCH 06/32] media: ccs: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 07/32] media: i2c: ds90ub913: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 08/32] media: i2c: ds90ub953: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 09/32] media: i2c: imx274: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 10/32] media: i2c: imx335: " Ricardo Ribalda
2025-10-13 15:03   ` Kieran Bingham
2025-10-13 15:06     ` Kieran Bingham
2025-10-13 15:55     ` Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 11/32] media: i2c: imx412: " Ricardo Ribalda
2025-10-14 21:09   ` Bryan O'Donoghue
2025-10-13 14:14 ` [PATCH 12/32] media: i2c: max9286: " Ricardo Ribalda
2025-10-13 15:09   ` Kieran Bingham
2025-10-13 14:14 ` [PATCH 13/32] media: i2c: max96717: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 14/32] media: i2c: mt9m111: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 15/32] media: i2c: mt9v111: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 16/32] media: i2c: ov5675: " Ricardo Ribalda
2025-10-14 21:10   ` Bryan O'Donoghue
2025-10-13 14:14 ` [PATCH 17/32] media: i2c: ov5693: " Ricardo Ribalda
2025-10-13 14:14 ` [PATCH 18/32] media: i2c: ov9282: " Ricardo Ribalda
2025-10-14 21:10   ` Bryan O'Donoghue
2025-10-13 14:14 ` [PATCH 19/32] media: rj54n1cb0c: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 20/32] media: i2c: st-mipid02: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 21/32] media: ipu-bridge: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 22/32] media: ipu3-cio2: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 23/32] media: ipu6: isys: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 24/32] media: mediatek: vcodec: " Ricardo Ribalda
2025-10-14 11:29   ` AngeloGioacchino Del Regno
2025-10-13 14:15 ` [PATCH 25/32] media: imx8mq-mipi-csi2: " Ricardo Ribalda
2025-10-14  7:07   ` Martin Kepplinger-Novakovic
2025-10-13 14:15 ` [PATCH 26/32] media: platform: rzg2l-cru: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 27/32] media: renesas: vsp1: " Ricardo Ribalda
2025-10-13 14:42   ` Geert Uytterhoeven
2025-10-13 14:15 ` Ricardo Ribalda [this message]
2025-10-13 14:15 ` [PATCH 29/32] media: samsung: exynos4-is: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 30/32] media: ti: cal " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 31/32] media: staging: ipu3-imgu: " Ricardo Ribalda
2025-10-13 14:15 ` [PATCH 32/32] media: staging/ipu7: " Ricardo Ribalda
2025-10-16 19:22 ` [PATCH 00/32] media: " Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251013-ptr_err-v1-28-2c5efbd82952@chromium.org \
    --to=ribalda@chromium.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=bingbu.cao@intel.com \
    --cc=dafna@fastmail.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=djrscally@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=hverkuil@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jacopo@jmondi.org \
    --cc=julien.massot@collabora.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=khalasa@piap.pl \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzk@kernel.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=leonl@leopardimaging.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martink@posteo.de \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=rmfrfs@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=s.nawrocki@samsung.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    --cc=sylvain.petinot@foss.st.com \
    --cc=tian.shu.qiu@intel.com \
    --cc=tiffany.lin@mediatek.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=y-abhilashchandra@ti.com \
    --cc=yong.zhi@intel.com \
    --cc=yunfei.dong@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).