From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F33F269D06 for ; Mon, 13 Oct 2025 14:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364897; cv=none; b=GaTWYo0B3F2gNmCgQ+fvNlxKfvI+GGwPn0tPTk8aG2fIhquNa06iwvUv3tG6YhndLQcBbzj0aexM5IMIAgb0FRXJxdKM4rpVZabYgwU3DWRHyvmXXgZ4hXVy4E6a+EmG161IzKshuSw0ER7lV/2iLVRVOY/tIVdqG6G0baKzpjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364897; c=relaxed/simple; bh=XGq0AYT0RAu45DkehU73efZ+CKhGLsp22KsMW3sZ7KM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FBV7XkFigQNy3ZHBW/RdZA08ReA3JY1r58/eleLzqMeesuWJ4FsGsa6Z0eeKmcPLjO6hlq+wuSSnLZQAZY9MlEQHEuBsxSigpJgYDTNmJ6GIRP179kS61VpYtCAETovL46Jxgs8k5LvetG62SBFG8SpU6ISrgzt4iH/H0ewzShU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cdr1hIq2; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cdr1hIq2" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-58affa66f2bso4585010e87.1 for ; Mon, 13 Oct 2025 07:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364892; x=1760969692; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cw6YFePVdJ/w0HUJNx+YTiAEhWK3QpB9xmEBqnhTSDQ=; b=cdr1hIq2jUiqlyHGLSraYFrMIEgscJ0C3ydDRuFlZqjZJ0QmjNxOHzRpUarGhnONZd T2dVSrsiuzxzW2E+F5lvJ/ymxtYRYlPh6mixBVDiXF8lG4jP6uStRtyY/LWNKWk8jApG wMspUiD0gImABlPWlgz6zQlaao1am/6ZcmJpY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364892; x=1760969692; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cw6YFePVdJ/w0HUJNx+YTiAEhWK3QpB9xmEBqnhTSDQ=; b=LPlSSqDcG3Gkoq7FWE67rh6jvrUhr+X5RVDtqvjLDRPTFqhuEtKIqq5/3QpFru21UB nNc0XOGvb77fwAwDvT9a8MLnoXHLMDZc52AMVEUVCQyUP+8Z9z+/mfX3xMYqihfbRS0D dUHXlw8TSme5kKYxwxm0nUqNJm6+vIche8lu7MDuSaj4iKVcBb/6uHGQj5HdbGF8kbnW pCknv/UM8MDnIKG80peJy39nesMwcU8/HifsydihIdMYc3X8p0iwj8k4xHjRFzDuO0d/ Dmf4XTe+HMSrHapMfXK/pxWmMik6D0HAkYaJq4/jytMCXLRNYh4kJiVO5BVgMprB4qI+ jvuw== X-Forwarded-Encrypted: i=1; AJvYcCWXrYZ3lOVk/FFsV8Mz3BmPqrbFK0llDvUWs6oCc5QV7dlhk0/UEQLR9GfufE5EV5DCsUvJls4j3lutyJ3T1SVLlQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yz882xFrwkXhIv+kFo4hQIeCtsJgsSP3sdBexycYNYc8cxiRO5S J3qUiDCKUY4apLknDh9M0oJ6T2TgQqQU2ZmM287EnQVVWzh9p+FZBKIiuZhchdzaWQ== X-Gm-Gg: ASbGncu6+rbJqVf5bQstmGwwuL1YL/+j8fTUpYAjFBU0TYgBkkCYLydnoCy915qUUhJ +GUnGgUaNYMYQPsA+SBWehmD72udwB8PUm8pp9DEy4dxdSv6aPF58Vhp+cS2ACurUiaDQ6tqnXY 64GqxAcLoQl2z5xlE1/ODs8o5C52XVLjKkbsbe9mxiU3lN1oowr3g81psfOBCIqYt+ROndWmwLu WdvYOK+vsDp6LjKkoNe8Y9HBOHCC3Yxqc4zpATwLwJkPwq+IWlRswBnYHQ6UflzrLR4V5CvRSmc X2vgWBAq37q8DexVv5y9OuWfbc1wJtxmHVOR0667BTqUPVBOhWIAi8Z1ACwfVjK0zBzJiISzYE1 cq8uVRmc0rQTUyIL6I0usiPbBs3djKwMFIzzsBTHHKWf9oBBkWcD+P9d3InweiRZpYxV0303fWA SlHrdfkMSkdGP0QVV88Q== X-Google-Smtp-Source: AGHT+IEKVe60oXFEuaV/5sAfkl2vR8IvNhsEsPje9O6F0QVcXOQ4CmYWAzNOjArzbT4yXoFh7KUNeA== X-Received: by 2002:a05:6512:2309:b0:57a:baaa:394 with SMTP id 2adb3069b0e04-5906dd51898mr4676162e87.27.1760364891849; Mon, 13 Oct 2025 07:14:51 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:14:51 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:14:43 +0000 Subject: [PATCH 03/32] media: mn88443x: Use %pe format specifier Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-3-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR() This patch fixes this cocci report: ./dvb-frontends/mn88443x.c:698:3-10: WARNING: Consider using %pe to print PTR_ERR() ./dvb-frontends/mn88443x.c:713:3-10: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-frontends/mn88443x.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/mn88443x.c b/drivers/media/dvb-frontends/mn88443x.c index 7a58f53ab9996031e319711a21b1a8f1c13abed4..818c4e67364c7c6ec2bfc17f21e2cac360f6bfb3 100644 --- a/drivers/media/dvb-frontends/mn88443x.c +++ b/drivers/media/dvb-frontends/mn88443x.c @@ -694,8 +694,7 @@ static int mn88443x_probe(struct i2c_client *client) chip->mclk = devm_clk_get(dev, "mclk"); if (IS_ERR(chip->mclk) && !conf) { - dev_err(dev, "Failed to request mclk: %ld\n", - PTR_ERR(chip->mclk)); + dev_err(dev, "Failed to request mclk: %pe\n", chip->mclk); return PTR_ERR(chip->mclk); } @@ -709,8 +708,8 @@ static int mn88443x_probe(struct i2c_client *client) chip->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(chip->reset_gpio)) { - dev_err(dev, "Failed to request reset_gpio: %ld\n", - PTR_ERR(chip->reset_gpio)); + dev_err(dev, "Failed to request reset_gpio: %pe\n", + chip->reset_gpio); return PTR_ERR(chip->reset_gpio); } -- 2.51.0.760.g7b8bcc2412-goog