linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH 11/14] dt-bindings: spi: renesas,rzv2h-rspi: document RZ/T2H and RZ/N2H
Date: Wed, 29 Oct 2025 17:58:48 +0000	[thread overview]
Message-ID: <20251029-relieving-prude-c097e63f368e@spud> (raw)
In-Reply-To: <20251028133151.1487327-12-cosmin-gabriel.tanislav.xa@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 3570 bytes --]

On Tue, Oct 28, 2025 at 03:31:42PM +0200, Cosmin Tanislav wrote:
> The Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs have four SPI
> peripherals.
> 
> Compared to the previously supported RZ/V2H, these SoCs have a smaller
> FIFO, no resets, and only two clocks: PCLKSPIn and PCLK. PCLKSPIn,
> being the clock from which the SPI transfer clock is generated, is the
> equivalent of the TCLK from V2H.
> 
> Document them, and use RZ/T2H as a fallback for RZ/N2H as the SPIs are
> entirely compatible.
> 
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  .../bindings/spi/renesas,rzv2h-rspi.yaml      | 62 ++++++++++++++++---
>  1 file changed, 52 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/renesas,rzv2h-rspi.yaml b/Documentation/devicetree/bindings/spi/renesas,rzv2h-rspi.yaml
> index ab27fefc3c3a..65ba120a6b23 100644
> --- a/Documentation/devicetree/bindings/spi/renesas,rzv2h-rspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/renesas,rzv2h-rspi.yaml
> @@ -9,12 +9,15 @@ title: Renesas RZ/V2H(P) Renesas Serial Peripheral Interface (RSPI)
>  maintainers:
>    - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>  
> -allOf:
> -  - $ref: spi-controller.yaml#
> -
>  properties:
>    compatible:
> -    const: renesas,r9a09g057-rspi # RZ/V2H(P)
> +    oneOf:
> +      - enum:
> +          - renesas,r9a09g057-rspi # RZ/V2H(P)
> +          - renesas,r9a09g077-rspi # RZ/T2H
> +      - items:
> +          - const: renesas,r9a09g087-rspi # RZ/N2H
> +          - const: renesas,r9a09g077-rspi # RZ/T2H
>  
>    reg:
>      maxItems: 1
> @@ -36,13 +39,12 @@ properties:
>        - const: tx
>  
>    clocks:
> +    minItems: 2
>      maxItems: 3
>  
>    clock-names:
> -    items:
> -      - const: pclk
> -      - const: pclk_sfr
> -      - const: tclk
> +    minItems: 2
> +    maxItems: 3
>  
>    resets:
>      maxItems: 2
> @@ -62,12 +64,52 @@ required:
>    - interrupt-names
>    - clocks
>    - clock-names
> -  - resets
> -  - reset-names
>    - power-domains
>    - '#address-cells'
>    - '#size-cells'
>  
> +allOf:
> +  - $ref: spi-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,r9a09g057-rspi
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 3
> +          maxItems: 3
> +
> +        clock-names:
> +          items:
> +            - const: pclk
> +            - const: pclk_sfr
> +            - const: tclk
> +
> +      required:
> +        - resets
> +        - reset-names
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,r9a09g077-rspi
> +              - renesas,r9a09g087-rspi

Do these platforms have optional resets? If they do not, please add
"resets: false" & "reset-names: false" below. If they do have optional
resets,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
If they don't, you can apply the tag when you add the ": false"s.

Cheers,
Conor.

> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +
> +        clock-names:
> +          items:
> +            - const: pclk
> +            - const: pclkspi
> +
>  unevaluatedProperties: false
>  
>  examples:
> -- 
> 2.51.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-10-29 17:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 13:31 [PATCH 00/14] Add RSPI support for RZ/T2H and RZ/N2H Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 01/14] clk: renesas: r9a09g077: add SPI module clocks Cosmin Tanislav
2025-10-28 13:39   ` Cosmin-Gabriel Tanislav
2025-10-28 13:31 ` [PATCH 02/14] spi: rzv2h-rspi: make resets optional Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 03/14] spi: rzv2h-rspi: make FIFO size chip-specific Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 04/14] spi: rzv2h-rspi: make clocks chip-specific Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 05/14] spi: rzv2h-rspi: move register writes out of rzv2h_rspi_setup_clock() Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 06/14] spi: rzv2h-rspi: avoid recomputing transfer frequency Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 07/14] spi: rzv2h-rspi: make transfer clock rate finding chip-specific Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 08/14] spi: rzv2h-rspi: add support for using PCLK for transfer clock Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 09/14] spi: rzv2h-rspi: add support for variable " Cosmin Tanislav
2025-10-31 12:02   ` Dan Carpenter
2025-10-28 13:31 ` [PATCH 10/14] spi: rzv2h-rspi: add support for loopback mode Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 11/14] dt-bindings: spi: renesas,rzv2h-rspi: document RZ/T2H and RZ/N2H Cosmin Tanislav
2025-10-29 17:58   ` Conor Dooley [this message]
2025-10-28 13:31 ` [PATCH 12/14] spi: rzv2h-rspi: add support for " Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 13/14] arm64: dts: renesas: r9a09g077: Add SPIs support Cosmin Tanislav
2025-10-28 13:31 ` [PATCH 14/14] arm64: dts: renesas: r9a09g087: " Cosmin Tanislav
  -- strict thread matches above, loose matches on Subject: below --
2025-11-05  9:13 [PATCH 00/14] Add RSPI support for RZ/T2H and RZ/N2H Cosmin Tanislav
2025-11-05  9:13 ` [PATCH 11/14] dt-bindings: spi: renesas,rzv2h-rspi: document " Cosmin Tanislav
2025-11-06 17:57   ` Conor Dooley
2025-11-06 18:02     ` Cosmin-Gabriel Tanislav
2025-11-07 17:00       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029-relieving-prude-c097e63f368e@spud \
    --to=conor@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).