Re: [PATCH v2 3/3] input: touchscreen: st1232: add system wakeup support

phucduc.bui
2026-03-07T02:50:19Z

Hi Krzysztof,

> > + dev_info(dev, "st1232: suspend called\n");
> > + dev_info(dev, "st1232: irq=%d wakeup=%d\n", client->irq,
> device_may_wakeup(dev));
>
> No, there is no need to add success messages.
>
> >
> > - if (!device_may_wakeup(&client->dev))
> > + if (device_may_wakeup(dev)) {
> > + ret = enable_irq_wake(client->irq);
> > + dev_info(dev, "st1232: Supend use wakeup\n");
> > + dev_info(dev, "enable_irq_wake ret=%d\n", ret);
>
> Drop both
>
>
> > + } else {
> > + dev_info(dev, "st1232: Suspend Don't use wakeup\n");
>
> Drop

My apologies. You are absolutely right. I realized these debug messages
were unnecessary and already removed them in the v3 I sent (though I
unfortunately messed up the threading for that version).
I will ensure they stay removed in v4, which will be sent as a fresh
thread.

Best regards,
Phuc