Re: [PATCH] src: gen-image: Fix compiler warning

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Paul,

Thank you for the patch.

On Thu, Sep 17, 2026 at 07:19:12PM +0900, Paul Elder wrote:
> Fix compiler warning for maybe uninitialized.

It's useful to record more detailed information when working around
compiler issues. I'll expand the commit message to


gcc reports an uninitialized variable when compiling with '-Os':

In function ‘process’,
    inlined from ‘main’ at ../src/gen-image.c:2359:8:
../src/gen-image.c:1722:12: error: ‘image’ may be used uninitialized [-Werror=maybe-uninitialized]
 1722 |         if (!input) {
      |            ^
../src/gen-image.c: In function ‘main’:
../src/gen-image.c:389:23: note: ‘image’ was declared here
  389 |         struct image *image;
      |                       ^~~~~

This appears to be a false positive. Work around it by initializing the
image variable to NULL when declaring it.

> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  src/gen-image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gen-image.c b/src/gen-image.c
> index 26d7f0d28417..401e1316ae5a 100644
> --- a/src/gen-image.c
> +++ b/src/gen-image.c
> @@ -386,7 +386,7 @@ static int pnm_read_integer(int fd)
>  
>  static struct image *pnm_read(const char *filename)
>  {
> -	struct image *image;
> +	struct image *image = NULL;
>  	unsigned int width;
>  	unsigned int height;
>  	char buffer[2];

-- 
Regards,

Laurent Pinchart