From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A0431A069 for ; Fri, 7 Nov 2025 10:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; cv=none; b=jhbh0WNPjed8lGbgDhe2tKqhrGgMZTr/hmwAqbPHWHf0vpB8mkfpGKnOT53lleStvYuC9qQsgX5IUIMZu90XLqfZxROkpXEBWe4UpofA/50++1rohyOCl8wCK75Qn56Tb3hlx6WdBQ/pwB5uksxByqhERdRx4dB/2r9Xj12XwLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; c=relaxed/simple; bh=k6CWVoo79rJIhFxcP1Zi6lbWRJyVheMfi9XXd+LkGTU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvnEGE2XnL9d/inR1bIq528MJSthDNSNWTgTSXlkfUPIt7MDGVR7PnjQCG+1yQW8v82YquIE/2GXqC5j6f6rthrhK3RqauN3R+6n2EXdKrLeAcxKTsmPVEeZZlTYbVpqOjAFE2Etp8Uk6WfuqOKH1AZhJ5BGOmpX5KiBiuWXxjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j19zi5vc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aVpK38KF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j19zi5vc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aVpK38KF" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A744k262085441 for ; Fri, 7 Nov 2025 10:49:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=j19zi5vcZvZc+J3h eil5EXgb7o+MHafKBi9Slf1MAsHwht9ShJKuhVBN4IuNbfkFvOasu8HUs+laic1i ApQFCQDDkr0nR1Z4s/mFsEJRFNaTWW7B62zkTCNyqa8FVCGzmDgnRi4aJaWpx3yo 7YBrhqEKVuWBhNuAaoE60NFeKFuxZH+p+rn0tyDvgwMCTDDPUaOdyqcmIN20Yni7 e+FAQn327eA/EMJkdOZ1oKcI5NWQiBeaIRCP9KmnXRYAWj3UM/IlF2kolv1vNI8Y 9Rr7K9olNJaawFxFkksQTdDzKZOepplYR1QpfkBYS3jwKcxtOTKS7ODirqnsgtuo rorS0A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a99e794y4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 10:49:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8906754b823so23149485a.0 for ; Fri, 07 Nov 2025 02:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762512597; x=1763117397; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=aVpK38KFUkFW6kHSwtDvmqmr+IpLTyoG+3Gj2IH6kwa7KJ9sRechIttPb6jEiqRkIT shiAQol5uzyZL7OUgnKhrLYoTq3W8g+FmNJbcRgmFmtueqEFfXqKIkbSdm79N+EIESeI aF+3ys97Ay+qY41i5G/AJleovoe3ssLGjj3GCoyw+2fE9EiRwzWu9P6n2/XX4K/FXjED qsJBWCUkM/9u6u8IC4/xzcXdaxlS43MobCRNrBQD58R2Sf8BOZLdDCMqwfNQF/EeLQJB 5EZ9ecmojBYR+VkpotxpmrkAps9jZPwIdB5DOTLaN0M9TgkFTXgSrepDr+q0gJ9yWJMy KY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762512597; x=1763117397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=tkcdU4NzsyIMtcH9FH8ooOKl4Go4hwXClDNyfHqRe2jtNQSFEWzoFPyv2e8Yw1IyC9 KqTeiZEmNyCF7c2rl3kPndA/hLUSWbuk/aMtzZhJ2cVWSTAodbdIC9V9NwxLvOipTlOo lovXyvlCG3Hq8zEZ8dL6W1G/KTXJzpsPS/hOUO+Evr7G3xBRdKX1QjmixKTuYOaRMqst XIxPeY0CHnDPDPD0E8CHUDJEYbwQ1CMWzUgeDTd/liPb3xsMJ/0BlHlrcXNNCsoBpgPq ipZgD6ogjU1DsgFxvBFStHz5if+rf1P0LatjPdoPxTlujvFNPPoLGV/nY30WkvSyrdLo 2DDg== X-Forwarded-Encrypted: i=1; AJvYcCVyf+hLtHDbcUXwVOJYeVZNKb2NP8YuYlg1h7KUA0rehYYOjlu3uXCVCP73UyDU64WXHFFIYYFLqUX+RChixfN+sA==@vger.kernel.org X-Gm-Message-State: AOJu0YyuaJ92pIR3i645YMLEbqf9yk4oZu8GohAYZv1o8MMLvi1wRuEO zL2mlbJ6GB77UC6hRCNKdZe4UrIIVpzylCmDZogJ8MXGr+LNNY9AwMKmLRvEZtRs3wIhul7cWCX sEbU+KuFbbQV2mM3INFCXA0NL1hJ9qhbSd/+lgyzj6NLaAKWJSiLMQ9xwiCRzTjURAbxWfFtGMA == X-Gm-Gg: ASbGncu6v/gZE7dZf6gmcgDjzVSTWGQ3hMkgRZo73P4CZUKNdkKzDs1ULmonZ6AmbNo hBk3bvNazRykXixs4rnwEGUBWif5hJTCHQqHnQCRXTRbxSUrQvtjoSBbJBTXQ0tT8hZRgXSX9bX AF0w6ZnZLIIf3RR8rA3eLqWBrSgfaSv3f1VLMJuhbqEtISky0JoTKrMQrOCiPEdHgGBnVW5XP3r lplmXpqRI97xpqMqWr2MCw/dXZAO7sZJtE3eC38YwRM5tPwuADIfWUABPJCSPiqajx91OA8JYoa OAsHoo/iqgMy2RtK3V0MaJLHvP+jt9uF8/3Uo37NFl8IqiyhtU0IZ6lyqA+Vd73+Nw5iytnni/0 Dd096M2KJCEKnCNKuSctMEJvCM0lin/cC3JQrIrnHSnisZfDumfMDkBD9 X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18063041cf.5.1762512596791; Fri, 07 Nov 2025 02:49:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFb3Xbou/G0Zzd63eLA+eutWoqm0V75Q2RL/wdtW4sHDSzQGKhPaQSn2W6oLQojU83FQkCi9A== X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18062921cf.5.1762512596362; Fri, 07 Nov 2025 02:49:56 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc2fcsm204678566b.50.2025.11.07.02.49.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 02:49:55 -0800 (PST) Message-ID: <21a3d269-76e6-4da9-aa25-bfd1fb6dfb07@oss.qualcomm.com> Date: Fri, 7 Nov 2025 11:49:48 +0100 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/8] net: stmmac: qcom-ethqos: use generic device properties To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4NyBTYWx0ZWRfX7+372sq/6PBv TtERcEP26yS3SFZcgyfZ0nkP+p9rJSmQgp5e0Wv1jN+wOpQLeoBCWx4WotRUeLSbgVwHKdDXv2q TRYCxqkSJMm8BRkqVAGEFQ2L/0nVnPnPoYAK3D1/qOsg99jBtq3VACqjg9fpDvso1LE63wx8uD1 Oh6GIAHl+NkGRqG0424/wDXaDvbYwZ68+fDqWLBHptoEY3fhYggBRW6oCq+vjRetWTff6ek7s+7 sAA6yERE7qt8rjaCK5tl44Z/OAtdGXbiB/q6a3kn/y2UZvZh7fkWBf8kMYvWyYQWHnIiO+yt4iH u6DeXIsnW7MgVIda4HFsQD9OvTu+Rr5kTC2HQ1Zzp+XbQ6bwwPsC/3+M28xaT48Ywm03gMVfAM4 35h0emcQQ+dHrSGo2engRL+qoGYFKQ== X-Proofpoint-ORIG-GUID: jQ6Tu6_-NQJXkJm1uaiK5x1rnMAeZCki X-Authority-Analysis: v=2.4 cv=A+hh/qWG c=1 sm=1 tr=0 ts=690dced5 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=xTS94RJRWet4TjKJq7QA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: jQ6Tu6_-NQJXkJm1uaiK5x1rnMAeZCki X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070087 On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to drop the dependency on CONFIG_OF, convert all device property > getters from OF-specific to generic device properties and stop pulling > in any linux/of.h symbols. > > Signed-off-by: Bartosz Golaszewski > --- [...] > - if (of_property_read_bool(np, "snps,tso")) > + if (device_property_present(dev, "snps,tso")) This is a change in behavior - "snps,tso = <0>" would have previously returned false, it now returns true although it seems like it's the plat driver clunkily working around not including the common compatible and inlining parts of the common probe functions.. Konrad