From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] sh_eth: sh_eth_close() always returns 0
Date: Wed, 2 Feb 2022 17:57:05 +0300 [thread overview]
Message-ID: <2de76f03-aea3-cfe4-72b3-a8b93c8b6dd1@gmail.com> (raw)
In-Reply-To: <CAMuHMdW_AufMOLJjtcO3hp-GwD0Q6iDL1=SD6Fq+Xe5wL46Yow@mail.gmail.com>
On 01.02.2022 11:58, Geert Uytterhoeven wrote:
[...]
>> sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
>> is pointless (however we cannot change the prototype of sh_eth_close() as
>> it implements the driver's ndo_stop() method).
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Note that there's a second call in sh_eth_suspend().
Made no sense to change it. :-)
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergey
next prev parent reply other threads:[~2022-02-02 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 11:55 [PATCH v2 0/2] Remove some dead code in the Renesas Ethernet drivers Sergey Shtylyov
2022-01-29 11:55 ` [PATCH v2 1/2] ravb: ravb_close() always returns 0 Sergey Shtylyov
2022-02-01 8:55 ` Geert Uytterhoeven
2022-01-29 11:55 ` [PATCH v2 2/2] sh_eth: sh_eth_close() " Sergey Shtylyov
2022-02-01 8:58 ` Geert Uytterhoeven
2022-02-02 14:57 ` Sergei Shtylyov [this message]
2022-01-31 11:50 ` [PATCH v2 0/2] Remove some dead code in the Renesas Ethernet drivers patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2de76f03-aea3-cfe4-72b3-a8b93c8b6dd1@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox