From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-renesas-soc-owner@vger.kernel.org>
Received: from mail-wm0-f65.google.com ([74.125.82.65]:35093 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1759759AbdALCDs (ORCPT
        <rfc822;linux-renesas-soc@vger.kernel.org>);
        Wed, 11 Jan 2017 21:03:48 -0500
Received: by mail-wm0-f65.google.com with SMTP id l2so673563wml.2
        for <linux-renesas-soc@vger.kernel.org>; Wed, 11 Jan 2017 18:03:19 -0800 (PST)
Subject: Re: [PATCH v2] arm64: dts: r8a7795: salvator-x: Add DU0 and DU3
 external dot clocks
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        linux-renesas-soc@vger.kernel.org
References: <20170112015121.2860-1-laurent.pinchart+renesas@ideasonboard.com>
From: Marek Vasut <marek.vasut@gmail.com>
Message-ID: <31e948b7-1e74-714e-af64-d66e1eb4fa06@gmail.com>
Date: Thu, 12 Jan 2017 02:56:14 +0100
MIME-Version: 1.0
In-Reply-To: <20170112015121.2860-1-laurent.pinchart+renesas@ideasonboard.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-renesas-soc-owner@vger.kernel.org
List-ID: <linux-renesas-soc.vger.kernel.org>

On 01/12/2017 02:51 AM, Laurent Pinchart wrote:
> The clocks are generated by an I2C-controlled programmable clock
> generator.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 26 ++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)
> 
> This patch depends on the clk-versaclock5 driver posted by Marek.
> 
> Changes since v1:
> 
> - Dropped the assigned-clocks properties
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> index 2dc0887fc400..5a13ddc5b497 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -178,6 +178,12 @@
>  		clock-frequency = <33000000>;
>  	};
>  
> +	x23_clk: x23-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <25000000>;
> +	};
> +
>  	hdmi0-out {
>  		compatible = "hdmi-connector";
>  		label = "HDMI0 OUT";
> @@ -271,10 +277,12 @@
>  		 <&cpg CPG_MOD 722>,
>  		 <&cpg CPG_MOD 721>,
>  		 <&cpg CPG_MOD 727>,
> +		 <&versaclock5 1>,
>  		 <&x21_clk>,
> -		 <&x22_clk>;
> +		 <&x22_clk>,
> +		 <&versaclock5 2>;
>  	clock-names = "du.0", "du.1", "du.2", "du.3", "lvds.0",
> -		      "dclkin.1", "dclkin.2";
> +		      "dclkin.0", "dclkin.1", "dclkin.2", "dclkin.3";
>  
>  	ports {
>  		port@0 {
> @@ -460,6 +468,20 @@
>  	};
>  };
>  
> +&i2c4 {
> +	status = "okay";
> +
> +	clock-frequency = <100000>;
> +
> +	versaclock5: clock-generator@6a {
> +		compatible = "idt,5p49v5923";
> +		reg = <0x6a>;
> +		#clock-cells = <1>;
> +		clocks = <&x23_clk>;
> +		clock-names = "xin";
> +	};
> +};
> +
>  &rcar_sound {
>  	pinctrl-0 = <&sound_pins &sound_clk_pins>;
>  	pinctrl-names = "default";
> 


-- 
Best regards,
Marek Vasut