From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A22CA4B for ; Sat, 21 Dec 2024 09:13:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734772425; cv=none; b=Qr4HoEUwfYKUFwQkttM9cf3EPClPqDXbTu4W0LihsCpB2pwq0VALsN2Qys5taNO88I+V3b2etmDlUriOZWusosanOLX8VY3n1sSR2/f3DH1PV1GTJHMGY5H81/qtDDzK8vNiyIAqJGoRMagwGYmhYZ+77b0IXyr6UXkBps+JYB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734772425; c=relaxed/simple; bh=Lj8kx4Y9m7dctN6JoafVbfe5c1zY4WJZ+HfAcFW3mrM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ig9fHtPLVnTP1DjbzQDHOGnok8XMs9WaL5s9xzl4/cBO0WSfeRDAchskPvl6k9pAKSdSfIP0l8H0Ziva+CtU4Vy2MYW/2QpkX49+xcZKyrH2679FOA00Im+FA97H7N6raBg5O5KnspHfxtIwnrR3uOHxKS9CRHKhBNHZ8nyAtRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=MW1WXWkE; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="MW1WXWkE" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-aa5f1909d6fso420690666b.3 for ; Sat, 21 Dec 2024 01:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1734772421; x=1735377221; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c7wkqfB5c/L++/PfkfJAIAEdiIVKbbltJZ6rUt2xDhc=; b=MW1WXWkEl3mNpF1ukgeHOLAJCjoHX4KUEDx4zDYV68sjTilI3nbzN+Lpj8OxIzQ4lY g5aoh5UpxtVnObFbNhk5l0kdfCzSpt1dGRJFRJ0Rk2VxQkDXJpDmd2+leM8jcpZW/qGP gjGzsFRC9ORLMqMeCKQ8p8Pigs1XJ0tu1TADy1WzyBgjfhG2Shqssy7pqtIseUnbhHwO 2tCm4oghcapRWIEGfl2U9PWp2oYQBTwcFUzd8l7d61tE9JdtcpE4h39EO57/g2aSLpGa oHbzcHLKAPEdTwrRAQjb4PS3+1DsCrVZYugAYjEY407JOO/2ZdaSwh9wNxlkAkbrqXCd 95bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734772421; x=1735377221; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c7wkqfB5c/L++/PfkfJAIAEdiIVKbbltJZ6rUt2xDhc=; b=KN7qpDl171bblwvOBMIONmKpQpjKtTxoFPJD80OhdVQHF3f17+5DpK78hxWrdjDV11 7VL8qp4IMk4VVrtepxyMh17auKKsEzqz9UibF+OMqc3sKspoZbk8Fzc3k6n5bOvKlqcI hbIWqIPN+Prg5FuLeWPHeqaTv/FVXM56WcBjAAn9P0oBTeWuM7sXFI0ZTE4O2353Pm0K xeqZEIXPdjFxEvYoukj1ftMtzdPxwTx048EgCNtauoYOPrV47L85R1RUM7DeKwI1z2kg sU7QVwIcxpBk52EbpzAeuFntSBUEY7uzNJXBZhm1HQhnWoejPuGpOi5njJkW1sLQyIio 3KVQ== X-Gm-Message-State: AOJu0Yxw2qc+FNvVK+bBs1DDJ1TQBm0Ap45b8accYzv1FfsGNALUADgn 2+Whf6k2fAU5PBesKViGrZ2SwHqvf3avkFJ5qTy+yaXhi3wk3wmu3vW8G3R8caY= X-Gm-Gg: ASbGncu++n+QxSyZVfFRCamI3CmuyKQG/Wci9nTOk91ND6cP4iSMh/2J3/uFcvCoh4w UnSujpK+a6ExcLTu4dxi73LgGdGNUFO9CvU9EgIVwvGl0KKSAbuA0xffwVbjMospwS2RCA+Dk/L nsd96Df8ucyS2k2kccQWdlHicII8NYawzsjsBkNPitJeY0SUB4ThZ+ZGqjY+WtBqCM+OSrkgXGv 2JxzcuFsh6tRUexmp6SjUBzvmS499T/jFtuNEC7+kxVzn2FY9kVSd0sZuZQxU2WFg== X-Google-Smtp-Source: AGHT+IG/UdUBKmFciOfZW9dMWRtaTXpcaIz9XIPHAn5lrbstD9Tb6jn1ZgFLja5AzW5NdsZcXutlTw== X-Received: by 2002:a17:907:9490:b0:aac:4ed:b4ec with SMTP id a640c23a62f3a-aac2ad8ab93mr528883966b.14.1734772421023; Sat, 21 Dec 2024 01:13:41 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.102]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e98f6bcsm260759466b.77.2024.12.21.01.13.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Dec 2024 01:13:40 -0800 (PST) Message-ID: <5242fffa-c028-49dd-a7cc-b6d9330f3c1c@tuxon.dev> Date: Sat, 21 Dec 2024 11:13:38 +0200 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 9/9] i2c: riic: Implement bus recovery To: Prabhakar , Chris Brandt , Andi Shyti , Philipp Zabel , Wolfram Sang , Geert Uytterhoeven Cc: linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar References: <20241218001618.488946-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20241218001618.488946-10-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <20241218001618.488946-10-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18.12.2024 02:16, Prabhakar wrote: > From: Lad Prabhakar > > Implement bus recovery by reinitializing the hardware to reset the bus > state and generating 9 clock cycles (and a stop condition) to release > the SDA line. > > Signed-off-by: Lad Prabhakar > --- > v1->v2 > - Used single register read to check SDA/SCL lines > --- > drivers/i2c/busses/i2c-riic.c | 100 ++++++++++++++++++++++++++++++---- > 1 file changed, 90 insertions(+), 10 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c > index 586092454bb2..d93c371a22de 100644 > --- a/drivers/i2c/busses/i2c-riic.c > +++ b/drivers/i2c/busses/i2c-riic.c > @@ -50,6 +50,7 @@ > [ ... ] > +static int riic_recover_bus(struct i2c_adapter *adap) > +{ > + struct riic_dev *riic = i2c_get_adapdata(adap); > + struct device *dev = riic->adapter.dev.parent; > + int ret; > + u8 val; > + > + ret = riic_init_hw(riic, true); > + if (ret) > + return -EINVAL; Any reason for not returning directly the ret? It is true the riic_init_hw() can, ATM, return only -EINVAL in case of failure. Thank you, Claudiu