From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C9FDC4743C for ; Wed, 23 Jun 2021 06:12:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2851A611C1 for ; Wed, 23 Jun 2021 06:12:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbhFWGOU (ORCPT ); Wed, 23 Jun 2021 02:14:20 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:45028 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbhFWGOT (ORCPT ); Wed, 23 Jun 2021 02:14:19 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id 75EF81F42F80 Message-ID: <52caf3779aa5b764bf193264cd5c5b8a542dea0a.camel@collabora.com> Subject: Re: [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml From: Ricardo =?ISO-8859-1?Q?Ca=F1uelo?= To: Laurent Pinchart , Geert Uytterhoeven Cc: David Airlie , Daniel Vetter , Michal Simek , alexandre.torgue@foss.st.com, Collabora Kernel ML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Rob Herring , Wei Xu , Maxime Coquelin , Marek Vasut , Linux-Renesas Date: Wed, 23 Jun 2021 08:11:51 +0200 In-Reply-To: References: <20210615131333.2272473-1-ricardo.canuelo@collabora.com> <20210615131333.2272473-4-ricardo.canuelo@collabora.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi, > On Fri, Jun 18, 2021 at 09:55:38AM +0200, Geert Uytterhoeven wrote: > > This causes lots of failures like: > > > > arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dt.yaml: hdmi@39: > > 'avdd-supply' is a required property > > > > Should all supplies be required? > > Looking at the driver, missing supplies are automatically replaced by > > dummy regulators by the regulator framework. > > Generally speaking, I like DT bindings to be descriptive of the > hardware, and thus require power supplies that are needed for the device > to function, even if they are fixed supplies. > > This being said, I think there's also room to group some power supplies > together in the bindings, when they are not meant by the device to be > controlled separately. In this specific case, we also need to take into > account that the adv7511 and adv7533 have different supplies. Thanks for the review, guys. Yes, there were some dtbs check warnings to be expected, the consensus in a previous version of the patch was that that shouldn't be a blocker for a binding conversion and that the *.dts definitions should eventually be fixed to comply with the binding, which is, IMO, a more reasonable process to keep the binding conversion effort progressing. Cheers, Ricardo