Re: [PATCH] PCI: rcar: Add compatible string for r8a7796

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello!

On 11/8/2017 12:15 PM, Marek Vasut wrote:

> From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
> 
> Add compatible string for the RCar M3 R8A7796 SoC.

    It's M3-W.

> Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>   drivers/pci/host/pcie-rcar.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 12796eccb2be..8b51208875fc 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -1062,6 +1062,7 @@ static const struct of_device_id rcar_pcie_of_match[] = {
>   	{ .compatible = "renesas,pcie-rcar-gen2",
>   	  .data = rcar_pcie_hw_init_gen2 },
>   	{ .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init },
> +	{ .compatible = "renesas,pcie-r8a7796", .data = rcar_pcie_hw_init },

    Why, if we already have the line below? And don't you need to update the 
bindings?

>   	{ .compatible = "renesas,pcie-rcar-gen3", .data = rcar_pcie_hw_init },
>   	{},
>   };

MBR, Sergei