Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible.

[Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>]

Hi Morimoto-san,

On 08/09/2020 01:34, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi"

Hrm, technically the driver will currently only match on :
  "renesas,rcar-gen3-hdmi"

But I see how the '-dw-' has probably snuck in from other devices, and
is inappropriate.

Perhaps this should be more clear that it matches on the generic compatible:
	renesas,rcar-gen3-hdmi

(or a combination of both?)

> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

But if the generic isn't required, then this patch alone does fix what I
would call an error, so ...

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

We could always make this more clear when converting to YAML.


> ---
>  .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> index 819f3e31013c..e6526ab485d0 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> @@ -42,7 +42,7 @@ Optional properties:
>  Example:
>  
>  	hdmi0: hdmi@fead0000 {
> -		compatible = "renesas,r8a7795-dw-hdmi";
> +		compatible = "renesas,r8a7795-hdmi";
>  		reg = <0 0xfead0000 0 0x10000>;
>  		interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>;
>  		clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>;
>