From: Marek Vasut <marek.vasut@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-clk <linux-clk@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5923B
Date: Tue, 10 Jan 2017 01:29:10 +0100 [thread overview]
Message-ID: <71b654d2-e24e-f09b-ca61-03dd7a27a24b@gmail.com> (raw)
In-Reply-To: <20170110002327.GI17126@codeaurora.org>
On 01/10/2017 01:23 AM, Stephen Boyd wrote:
> On 01/05, Marek Vasut wrote:
>> On 01/05/2017 03:13 PM, Laurent Pinchart wrote:
>>> Hi Marek,
>>
>> Hi!
>>
>> [...]
>>
>>>>>>> +static unsigned long vc5_mux_recalc_rate(struct clk_hw *hw,
>>>>>>> + unsigned long parent_rate)
>>>>>>> +{
>>>>>>> + struct vc5_driver_data *vc5 =
>>>>>>> + container_of(hw, struct vc5_driver_data, clk_mux);
>>>>>>> + unsigned long idiv;
>>>>>>> + u8 div;
>>>>>>> +
>>>>>>> + /* FIXME: Needs locking ? */
>>>>>
>>>>> Let's fix it then :-)
>>>>
>>>> I would like to get feedback on this one, does it ?
>>>
>>> That's a question for Mike or Stephen I believe.
>>
>> OK
>
> What's the question?
Whether or not I need a lock around the code in vc5_mux_recalc_rate(),
since I am also tweaking the predivider bits there to assure the
(downstream) PLL supplied from the mux always gets clock in range it can
handle. This tweaking is mostly inspired by clk-si5351.c driver.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-01-10 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161228000045.4540-1-marek.vasut@gmail.com>
2017-01-02 13:46 ` [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5923B Geert Uytterhoeven
2017-01-03 12:18 ` Laurent Pinchart
2017-01-04 16:21 ` Marek Vasut
2017-01-05 14:13 ` Laurent Pinchart
2017-01-05 15:44 ` Marek Vasut
2017-01-10 0:23 ` Stephen Boyd
2017-01-10 0:29 ` Marek Vasut [this message]
2017-01-10 0:44 ` Stephen Boyd
2017-01-10 17:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b654d2-e24e-f09b-ca61-03dd7a27a24b@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).