From: Marek Vasut <marek.vasut@mailbox.org>
To: Matt Coster <Matt.Coster@imgtec.com>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Frank Binns" <Frank.Binns@imgtec.com>,
"Alessio Belle" <Alessio.Belle@imgtec.com>,
"Alexandru Dadu" <Alexandru.Dadu@imgtec.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Rob Herring" <robh@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: gpu: img,powervr-rogue: Document GE7800 GPU in Renesas R-Car M3-N
Date: Tue, 4 Nov 2025 14:59:10 +0100 [thread overview]
Message-ID: <773b410d-26ad-4581-9de5-a2559891a3f7@mailbox.org> (raw)
In-Reply-To: <32d2db33-8477-45ea-ba41-5150ed750a59@imgtec.com>
On 11/4/25 1:36 PM, Matt Coster wrote:
Hello Matt,
>>>> @@ -105,6 +109,7 @@ allOf:
>>>> compatible:
>>>> contains:
>>>> enum:
>>>> + - img,img-ge7800
>>>> - img,img-gx6250
>>>
>>> Can you put these in the same order they're declared above? The way I
>>> read it, the order is img,xxx in generational order followed by
>>> soc-specific entries in alphabetical order (which is why we have
>>> img,img-gx6250 before img,img-bxs-4-64 below).
>>
>> In this enum, the entries are (should be) sorted alphabetically .
>>
>> Do you want to sort them generationally instead ?
>
> If we have it wrong and the correct way is that these should always be
> alphabetical, can you please fix up the existing enum below (with gx6250
> before bxs-4-64) to match the constraint too?
Fixed in V2, thanks !
prev parent reply other threads:[~2025-11-04 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 20:07 [PATCH 1/2] dt-bindings: gpu: img,powervr-rogue: Document GE7800 GPU in Renesas R-Car M3-N Marek Vasut
2025-11-03 20:07 ` [PATCH 2/2] arm64: dts: renesas: r8a77965: Add GE7800 GPU node Marek Vasut
2025-11-04 9:03 ` Geert Uytterhoeven
2025-11-03 21:25 ` [PATCH 1/2] dt-bindings: gpu: img,powervr-rogue: Document GE7800 GPU in Renesas R-Car M3-N Rob Herring (Arm)
2025-11-03 23:01 ` Marek Vasut
2025-11-04 7:37 ` Krzysztof Kozlowski
2025-11-04 9:01 ` Geert Uytterhoeven
2025-11-04 11:52 ` Matt Coster
2025-11-04 12:00 ` Marek Vasut
2025-11-04 12:36 ` Matt Coster
2025-11-04 13:59 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773b410d-26ad-4581-9de5-a2559891a3f7@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Alessio.Belle@imgtec.com \
--cc=Alexandru.Dadu@imgtec.com \
--cc=Frank.Binns@imgtec.com \
--cc=Matt.Coster@imgtec.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magnus.damm@gmail.com \
--cc=mripard@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).