From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D4762D4802 for ; Tue, 12 Aug 2025 19:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755027166; cv=none; b=LPKX5BPcKS/0kD8hQGvSkoa2rAvhY2Hq9e3CWIXxjQL/PV7HUFOArgMNRgNV5p6eqQqkAy7HieVW6lh9tEE0VWMmjgZzLMXVXdlV95rl5v+V+KKSfSnCgByI/1xCQaERvEWHyQWGttxKmc52gdyObvWkKD+x4XwgsZWdGrFdkLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755027166; c=relaxed/simple; bh=qNCXc0fX1iEpUfJfTz4NL6b9yWrU3TOOOXwxzw3DxWw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tPUzYDYjXJu9BzBqBRJsSjU+ZKwGzIA0F6yYf7OemVMBp9bLntZAyKNlNSd28g2l7m2D1X/KbRyEdnt2xM4lrWW7j4gfrmkNv1yV6jbl256bo+AMvbdiIJSB7ko1OoSjhKLiy5erV05UHImTwUTJ2RkugLkEegw5BOMwb2dhxOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=isGLSVFf; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=v8Oo9xmn; arc=none smtp.client-ip=80.241.56.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="isGLSVFf"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="v8Oo9xmn" Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4c1hVL2C70z9tT2; Tue, 12 Aug 2025 21:32:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1755027162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l/WiFwrTsFdNOCl1ddmrghHUFlzQt17sb2ZxRbYTeDo=; b=isGLSVFf2AFKMRvKxV/rlbqTj4VwZLqj4t/psB/HgARbh53EdsetHMe4rdznGNmFW9LX91 ZY0QyrVNwzCpk7qUCPkCLdpY8kiRKnrtlnpE4R94ilG0WI3+HliuuVXPia/tAWTCmtGfAb VSo17PwY7WI7pDQ4lpoH/D5HPIGFeR+x6mMgj7VAk/X3qBv3zgfn8kWU+4BZgR49aPS8ER tNqYzCJNDRgRD+OUD1Br9jIJ2TKf5h4A7WguT+LCxklNli+g0wZy6bZCNaGVHl0XYoWjTW bLubtBGk8w3W1e2DU4rQcKVgkwdqEWx9ByC4YxlhcOAfFnKz4BqWpBO0bNQZWw== Authentication-Results: outgoing_mbo_mout; dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=v8Oo9xmn; spf=pass (outgoing_mbo_mout: domain of marek.vasut@mailbox.org designates 2001:67c:2050:b231:465::202 as permitted sender) smtp.mailfrom=marek.vasut@mailbox.org Message-ID: <7dc2c17d-9879-41c8-b90d-19f92a2d9c1e@mailbox.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1755027160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l/WiFwrTsFdNOCl1ddmrghHUFlzQt17sb2ZxRbYTeDo=; b=v8Oo9xmnrfPuUYEj3ltfP+ZRVuakOtUx1du3rKgkAxzqEiXGoH7LmEDEqLwdhxF5qekS+i MtBDkG/2Z+QDcPSl9gPp3BPEDOEN/HsbxuyRgo0qVstbwmi6uhdL8lTgINwCTEYwlQb0MU WuPbNGAFbSESy4FRoeOLoG+KKLZbSdz2eKLEX8vTJly3TnqIuJaVCeu8CGjDm430i9HYGT eo5q8W++CcaZIXpINucSZVDQ2A8Rj6YJZy7BYaBcSMAuup2EZ6/aOt4w/o9IggzFFfI7Mk ZwJAgT6lTcdGmgo34YHF3D1TSA5sZ2dXIFHEgRzJLAA/5fyiHRIIGMnCKu8eFQ== Date: Tue, 12 Aug 2025 21:32:36 +0200 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/4] drm/rcar-du: dsi: Convert register bits to BIT() macro To: Tomi Valkeinen , Marek Vasut , dri-devel@lists.freedesktop.org Cc: David Airlie , Geert Uytterhoeven , Kieran Bingham , Laurent Pinchart , Maarten Lankhorst , Magnus Damm , Maxime Ripard , Simona Vetter , Thomas Zimmermann , linux-renesas-soc@vger.kernel.org References: <20250608142636.54033-1-marek.vasut+renesas@mailbox.org> <20250608142636.54033-2-marek.vasut+renesas@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-META: 4dekj3h9rz5srpbr8wk5tx9mxxag6pap X-MBO-RS-ID: 25962b9a37ccb198382 X-Rspamd-Queue-Id: 4c1hVL2C70z9tT2 On 8/12/25 3:26 PM, Tomi Valkeinen wrote: Hi, >> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h >> index a6b276f1d6ee..b3e57217ae63 100644 >> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h >> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h [...] >> @@ -51,11 +51,11 @@ >> >> #define TXVMVPRMSET0R 0x1d0 >> #define TXVMVPRMSET0R_HSPOL_HIG (0 << 17) >> -#define TXVMVPRMSET0R_HSPOL_LOW (1 << 17) >> +#define TXVMVPRMSET0R_HSPOL_LOW BIT(17) > > I'm not sure about this (and below). We have two defines for the HSPOL, > high and low. If one of them is (x << y), shouldn't the other one be of > that style too? It is inconsistent, but one macro describes bit set to 0 and the other bit set to 1 (i.e. the actual bit) which is converted to BIT(n) macro. I would be tempted to remove the bits set to 0, that's probably the real discussion that should happen here. But that would also be a much bigger patch. What do you think ?