RE: [PATCH 3/3] irqchip/renesas-rzg2l: Add NMI support

Biju Das
2026-03-31T17:35:07Z

Hi Wolfram Sang,

Thanks for the feedback.

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Sent: 28 March 2026 16:19
> Subject: Re: [PATCH 3/3] irqchip/renesas-rzg2l: Add NMI support
>
>
> > +static const struct irq_chip rzg2l_irqc_nmi_chip = {
> > + .name = "rzg2l-irqc",
>
> "rzg2l-irqc-nmi" maybe?

irq chip for tint and external interrupt are using "rzg2l-irqc"
for consistency "rzg2l-irqc" better compared to "rzg2l-irqc-nmi"

It reduces memory as a single pointer will be used in the
structure and also reduces number of changes.

Otherwise, we need to change

rzg2l-irqc-irq --> RZ/G2L irq interrupt
rzg2l-irqc-tint--> RZ/G2L tint interrupt
rzg2l-irqc-nmi --> RZ/{G2L,Five} nmi interrupt

rzfive-irqc-irq--> RZ/Five irq interrupt
rzfive-irqc-tint--> RZ/Five tint interrupt

Cheers,
Biju