From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names
Date: Wed, 15 Mar 2023 08:53:16 +0100 [thread overview]
Message-ID: <89bb07be-e11d-e248-8798-08b8531e68c7@linaro.org> (raw)
In-Reply-To: <20230315064726.22739-1-biju.das.jz@bp.renesas.com>
On 15/03/2023 07:47, Biju Das wrote:
> Document clock-names and reset-names properties as we have multiple
> clocks and resets.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> .../devicetree/bindings/dma/renesas,rz-dmac.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> index f638d3934e71..c284abc6784a 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> @@ -54,6 +54,11 @@ properties:
> - description: DMA main clock
> - description: DMA register access clock
>
> + clock-names:
> + items:
> + - const: main
> + - const: register
> +
> '#dma-cells':
> const: 1
> description:
> @@ -77,16 +82,23 @@ properties:
> - description: Reset for DMA ARESETN reset terminal
> - description: Reset for DMA RST_ASYNC reset terminal
>
> + reset-names:
> + items:
> + - const: arst
> + - const: rst_async
> +
> required:
> - compatible
> - reg
> - interrupts
> - interrupt-names
> - clocks
> + - clock-names
> - '#dma-cells'
> - dma-channels
> - power-domains
> - resets
> + - reset-names
The clock and reset entries are ordered anyway, so requiring '-names' is
not really necessary.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-15 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 6:47 [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names Biju Das
2023-03-15 6:47 ` [PATCH 2/2] arm64: dts: renesas: Add clock-names and reset-names to DMAC node Biju Das
2023-03-30 9:10 ` Geert Uytterhoeven
2023-03-15 7:53 ` Krzysztof Kozlowski [this message]
2023-03-17 17:27 ` [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89bb07be-e11d-e248-8798-08b8531e68c7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox