Re: [PATCH 2/3] drm/rockchip: Resolve dependency in GEM DMA helpers

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1799 bytes --]

Hi

Am 20.06.23 um 15:56 schrieb Jonas Karlman:
> Hi Thomas,
> 
> On 2023-06-20 14:03, Thomas Zimmermann wrote:
>> Remove the dependency on the GEM DMA helper library. Rockchip comes
>> with its own implementation of the GEM interface. It only uses the VM
>> callbacks in drm_gem_dma_vm_ops from the GEM DMA helpers. These are
>> not DMA specific.
>>
>> Duplicate drm_gem_dma_vm_ops in rockchip and remove all dependencies on
>> the GEM DMA helper library.
> 
> I have intentions to remove the entire custom implementation of the GEM
> interface and replace it with use of GEM DMA helpers in a future series.
> 
> Current custom implementation break import of video framebuffers located
> in memory beyond 4GB. Switching to use pure GEM DMA helpers solved that
> issue but requires reworking IOMMU integration for full support of
> multiple VOPs on e.g., RK3288 and RK3399.
> 
> I have no ETA on when such series can be ready so this is more of a
> heads up that I will revert this removal of dependency on GEM DMA helper
> library in a future series.

No problem. I'm only interested in cleaning up the current interfaces. 
Rockchip can easily switch to real GEM DMA code.

Best regards
Thomas

> 
> Regards,
> Jonas
> 
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>   drivers/gpu/drm/rockchip/Kconfig            | 1 -
>>   drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +-
>>   drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 ++++++--
>>   3 files changed, 7 insertions(+), 4 deletions(-)
>>
> [snip]

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]