Re: [PATCH v2 2/2] reset: always include RESET_GPIO driver if possible

[Philipp Zabel <p.zabel@pengutronix.de>]

On Do, 2025-10-16 at 15:02 +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Thu, 16 Oct 2025 at 14:16, Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > Reset core uses the reset_gpio driver for a fallback mechanism. So,
> > include it always once its dependencies are met to enable the fallback
> > mechanism whenever possible. This avoids regressions when drivers remove
> > open coded solutions in favor of this fallback.
> > 
> > Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Closes: https://lore.kernel.org/r/87a51um1y1.wl-kuninori.morimoto.gx@renesas.com
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Thanks for your patch!
> 
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -5,6 +5,7 @@ config ARCH_HAS_RESET_CONTROLLER
> >  menuconfig RESET_CONTROLLER
> >         bool "Reset Controller Support"
> >         default y if ARCH_HAS_RESET_CONTROLLER
> > +       select RESET_GPIO if GPIOLIB
> >         help
> >           Generic Reset Controller support.
> > 
> 
> Makes sense, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> This does mean RESET_GPIO will never be modular anymore, while it could
> still work as a module (the reset core creates the platform device,
> which can be probed later), albeit in a non-intuitive way.

Btw, Bartosz (added to Cc:) is reworking reset-gpio into an auxiliary
device driver.

[1] https://lore.kernel.org/all/20251006-reset-gpios-swnodes-v1-0-6d3325b9af42@linaro.org/

> BTW, could we run into a circular dependency?
> 
>     config RESET_TI_TPS380X
>             tristate "TI TPS380x Reset Driver"
>             select GPIOLIB
> 
> I guess this should be changed from select to depends on?

The drivers referencing GPIOLIB seem to be split in the middle between
select and depends...

regards
Philipp