linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [geert-renesas-devel:renesas-drivers-for-v6.18 1/1] drivers/soc/renesas/rz-sysc.c:113:16: error: cleanup argument not a function
@ 2025-08-19 13:54 kernel test robot
  2025-08-19 14:26 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-08-19 13:54 UTC (permalink / raw)
  To: John Madieu
  Cc: oe-kbuild-all, linux-renesas-soc, Geert Uytterhoeven,
	Claudiu Beznea

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git renesas-drivers-for-v6.18
head:   75601ffaea537c3180f23912ce1d0ed5f716469d
commit: 75601ffaea537c3180f23912ce1d0ed5f716469d [1/1] soc: renesas: rz-sysc: Add syscon/regmap support
config: arm-randconfig-001-20250819 (https://download.01.org/0day-ci/archive/20250819/202508192154.jtZINmab-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250819/202508192154.jtZINmab-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508192154.jtZINmab-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/soc/renesas/rz-sysc.c: In function 'rz_sysc_probe':
>> drivers/soc/renesas/rz-sysc.c:113:16: error: cleanup argument not a function
     113 |         struct regmap_config *regmap_cfg __free(kfree) = kzalloc(sizeof(*regmap_cfg), GFP_KERNEL);
         |                ^~~~~~~~~~~~~
>> drivers/soc/renesas/rz-sysc.c:113:58: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
     113 |         struct regmap_config *regmap_cfg __free(kfree) = kzalloc(sizeof(*regmap_cfg), GFP_KERNEL);
         |                                                          ^~~~~~~
>> drivers/soc/renesas/rz-sysc.c:113:58: warning: initialization of 'struct regmap_config *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   cc1: some warnings being treated as errors


vim +113 drivers/soc/renesas/rz-sysc.c

   103	
   104	static int rz_sysc_probe(struct platform_device *pdev)
   105	{
   106		const struct rz_sysc_init_data *data;
   107		const struct of_device_id *match;
   108		struct device *dev = &pdev->dev;
   109		struct regmap *regmap;
   110		struct rz_sysc *sysc;
   111		int ret;
   112	
 > 113		struct regmap_config *regmap_cfg __free(kfree) = kzalloc(sizeof(*regmap_cfg), GFP_KERNEL);
   114		if (!regmap_cfg)
   115			return -ENOMEM;
   116	
   117		match = of_match_node(rz_sysc_match, dev->of_node);
   118		if (!match)
   119			return -ENODEV;
   120	
   121		data = match->data;
   122	
   123		sysc = devm_kzalloc(dev, sizeof(*sysc), GFP_KERNEL);
   124		if (!sysc)
   125			return -ENOMEM;
   126	
   127		sysc->base = devm_platform_ioremap_resource(pdev, 0);
   128		if (IS_ERR(sysc->base))
   129			return PTR_ERR(sysc->base);
   130	
   131		sysc->dev = dev;
   132		ret = rz_sysc_soc_init(sysc, match);
   133		if (ret)
   134			return ret;
   135	
   136		regmap_cfg->name = "rz_sysc_regs";
   137		regmap_cfg->reg_bits = 32;
   138		regmap_cfg->reg_stride = 4;
   139		regmap_cfg->val_bits = 32;
   140		regmap_cfg->fast_io = true;
   141		regmap_cfg->max_register = data->max_register;
   142	
   143		regmap = devm_regmap_init_mmio(dev, sysc->base, regmap_cfg);
   144		if (IS_ERR(regmap))
   145			return PTR_ERR(regmap);
   146	
   147		return of_syscon_register_regmap(dev->of_node, regmap);
   148	}
   149	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [geert-renesas-devel:renesas-drivers-for-v6.18 1/1] drivers/soc/renesas/rz-sysc.c:113:16: error: cleanup argument not a function
  2025-08-19 13:54 [geert-renesas-devel:renesas-drivers-for-v6.18 1/1] drivers/soc/renesas/rz-sysc.c:113:16: error: cleanup argument not a function kernel test robot
@ 2025-08-19 14:26 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2025-08-19 14:26 UTC (permalink / raw)
  To: kernel test robot
  Cc: John Madieu, oe-kbuild-all, linux-renesas-soc, Claudiu Beznea

Hi Robot,

On Tue, 19 Aug 2025 at 15:54, kernel test robot <lkp@intel.com> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git renesas-drivers-for-v6.18
> head:   75601ffaea537c3180f23912ce1d0ed5f716469d
> commit: 75601ffaea537c3180f23912ce1d0ed5f716469d [1/1] soc: renesas: rz-sysc: Add syscon/regmap support
> config: arm-randconfig-001-20250819 (https://download.01.org/0day-ci/archive/20250819/202508192154.jtZINmab-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 12.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250819/202508192154.jtZINmab-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508192154.jtZINmab-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
>    drivers/soc/renesas/rz-sysc.c: In function 'rz_sysc_probe':
> >> drivers/soc/renesas/rz-sysc.c:113:16: error: cleanup argument not a function
>      113 |         struct regmap_config *regmap_cfg __free(kfree) = kzalloc(sizeof(*regmap_cfg), GFP_KERNEL);
>          |                ^~~~~~~~~~~~~
> >> drivers/soc/renesas/rz-sysc.c:113:58: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
>      113 |         struct regmap_config *regmap_cfg __free(kfree) = kzalloc(sizeof(*regmap_cfg), GFP_KERNEL);
>          |                                                          ^~~~~~~
> >> drivers/soc/renesas/rz-sysc.c:113:58: warning: initialization of 'struct regmap_config *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>    cc1: some warnings being treated as errors

Thank you, adding

    #include <linux/slab.h>

fixes that.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-19 14:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 13:54 [geert-renesas-devel:renesas-drivers-for-v6.18 1/1] drivers/soc/renesas/rz-sysc.c:113:16: error: cleanup argument not a function kernel test robot
2025-08-19 14:26 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).