From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f194.google.com ([209.85.223.194]:33492 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970052AbdAFKSL (ORCPT ); Fri, 6 Jan 2017 05:18:11 -0500 MIME-Version: 1.0 In-Reply-To: <20170103230639.19660-8-laurent.pinchart+renesas@ideasonboard.com> References: <20170103230639.19660-1-laurent.pinchart+renesas@ideasonboard.com> <20170103230639.19660-8-laurent.pinchart+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Fri, 6 Jan 2017 11:17:36 +0100 Message-ID: Subject: Re: [PATCH 07/19] sh: Don't set sh-sci port_reg To: Laurent Pinchart Cc: Linux-Renesas , Linux-sh list , "linux-serial@vger.kernel.org" , Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Jan 4, 2017 at 12:06 AM, Laurent Pinchart wrote: > The driver considers all negative or zero values of the port_reg field > as invalid. The four platforms that set the field to a register address > all use an address higher than 0x7fffffff, which is thus considered by > the driver as invalid. The feature is thus never used, remove it. Yeah, it's been broken since v3.1 (commit 514820eb982eb856 ("serial: sh-sci: Consolidate RXD pin handling")). > The feature could be implemented properly in the future using the > pinctrl and GPIO APIs if desired. > > While at it, don't set the field to SCIx_NOT_SUPPORTED (-1) either, > leaving it unset leads to the same result. This will allow removing the > SCIx_NOT_SUPPORTED macro. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds