Re: [PATCH] arm64: dts: renesas: r8a77990-ebisu: sort nodes

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Kaneko-san,

On Thu, Aug 1, 2019 at 4:24 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> Sort nodes.
>
> If node address is present
>    * Sort by node address, grouping all nodes with the same compat string
>      and sorting the group alphabetically.
> Else
>    * Sort alphabetically
>
> This should not have any run-time effect.
>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts

> @@ -157,15 +125,13 @@
>                 regulator-always-on;
>         };
>
> -       vbus0_usb2: regulator-vbus0-usb2 {
> +       reg_12p0v: regulator2 {
>                 compatible = "regulator-fixed";
> -
> -               regulator-name = "USB20_VBUS_CN";
> -               regulator-min-microvolt = <5000000>;
> -               regulator-max-microvolt = <5000000>;
> -
> -               gpio = <&gpio6 4 GPIO_ACTIVE_HIGH>;
> -               enable-active-high;
> +               regulator-name = "D12.0V";
> +               regulator-min-microvolt = <12000000>;
> +               regulator-max-microvolt = <12000000>;
> +               regulator-boot-on;
> +               regulator-always-on;
>         };
>
>         rsnd_ak4613: sound {

You forgot to sort the sound subnodes.

@@ -142,13 +142,13 @@
                simple-audio-card,bitclock-master = <&sndcpu>;
                simple-audio-card,frame-master = <&sndcpu>;

-               sndcpu: simple-audio-card,cpu {
-                       sound-dai = <&rcar_sound>;
-               };
-
                sndcodec: simple-audio-card,codec {
                        sound-dai = <&ak4613>;
                };
+
+               sndcpu: simple-audio-card,cpu {
+                       sound-dai = <&rcar_sound>;
+               };
        };

        vbus0_usb2: regulator-vbus0-usb2 {

As this kind of patches is a hell to rebase/rework, I'll fix that up myself
while appying.

Apart from that:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.4.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds