From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f66.google.com ([209.85.214.66]:36397 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161380AbdAFK1H (ORCPT ); Fri, 6 Jan 2017 05:27:07 -0500 MIME-Version: 1.0 In-Reply-To: <20170103230639.19660-12-laurent.pinchart+renesas@ideasonboard.com> References: <20170103230639.19660-1-laurent.pinchart+renesas@ideasonboard.com> <20170103230639.19660-12-laurent.pinchart+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Fri, 6 Jan 2017 11:27:05 +0100 Message-ID: Subject: Re: [PATCH 11/19] sh: Don't set the sh-sci platform data REIE bit when not implemented To: Laurent Pinchart Cc: Linux-Renesas , Linux-sh list , "linux-serial@vger.kernel.org" , Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Laurent, On Wed, Jan 4, 2017 at 12:06 AM, Laurent Pinchart wrote: > According to the datasheets, the sh7760 SIM and sh7723 SCIFA instances > don't implement the REIE bit. Don't set it in platform data. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven > --- > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 1 - > arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/arch/sh/kernel/cpu/sh4/setup-sh7760.c b/arch/sh/kernel/cpu/sh4/setup-sh7760.c > index 6dbcbf1621aa..e51fe1734e13 100644 > --- a/arch/sh/kernel/cpu/sh4/setup-sh7760.c > +++ b/arch/sh/kernel/cpu/sh4/setup-sh7760.c > @@ -200,7 +200,6 @@ static struct platform_device scif2_device = { > }; > > static struct plat_sci_port scif3_platform_data = { > - .scscr = SCSCR_REIE, Note that this bit does have a function (WAIT_IE --- Enables wait error interrupt (SIMERI) requests), so this may impact behavior. > /* > * This is actually a SIM card module serial port, based on an SCI with > * additional registers. The sh-sci driver doesn't support the SIM port Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds