From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v3 5/7] pinctrl: renesas: rzg2l: Unify OEN handling across RZ/{G2L,V2H,V2N}
Date: Thu, 7 Aug 2025 09:01:31 +0200 [thread overview]
Message-ID: <CAMuHMdW=-O3NDjgNSGa8GFArp9wJ0CFRmbFbTKcZ-mW=TCiTOQ@mail.gmail.com> (raw)
In-Reply-To: <20250806195555.1372317-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Wed, 6 Aug 2025 at 21:56, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Unify the OEN handling on RZ/V2H(P) and RZ/V2N SoCs by reusing the existing
> rzg2l_read_oen and rzg2l_write_oen functions from RZ/G2L. Add a
> pin_to_oen_bit callback in rzg2l_pinctrl_data to look up per-pin OEN bit
> positions, and introduce an oen_pwpr_lock flag in the hwcfg to manage PWPR
> locking on SoCs that require it (RZ/V2H(P) family). Remove the hardcoded
> PFC_OEN define and obsolete per-SoC OEN helpers.
>
> Also drop redundant checks for the OEN offset in the suspend/resume paths,
> as all supported SoCs now provide a valid offset through the `regs.oen`
> field.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
> - Grouped oen_pwpr_lock flag with other bools
> - Dropped redundant checks for OEN offset in suspend/resume paths
> - Updated the commit message to reflect the changes
> - Added Reviewed-by tag from Geert.
Thanks, will queue in renesas-pinctrl for v6.18.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2025-08-07 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 19:55 [PATCH v3 0/7] pinctrl: renesas: rzg2l: Unify OEN handling Prabhakar
2025-08-06 19:55 ` [PATCH v3 1/7] pinctrl: renesas: rzg2l: Fix invalid unsigned return in rzg3s_oen_read() Prabhakar
2025-08-07 6:59 ` Geert Uytterhoeven
2025-08-06 19:55 ` [PATCH v3 2/7] pinctrl: renesas: rzg2l: parameterize OEN register offset Prabhakar
2025-08-07 6:59 ` Geert Uytterhoeven
2025-08-06 19:55 ` [PATCH v3 3/7] pinctrl: renesas: rzg2l: Unify OEN access by making pin-to-bit mapping configurable Prabhakar
2025-08-07 7:00 ` Geert Uytterhoeven
2025-08-06 19:55 ` [PATCH v3 4/7] pinctrl: renesas: rzg2l: Remove OEN ops for RZ/G3E Prabhakar
2025-08-07 7:01 ` Geert Uytterhoeven
2025-08-06 19:55 ` [PATCH v3 5/7] pinctrl: renesas: rzg2l: Unify OEN handling across RZ/{G2L,V2H,V2N} Prabhakar
2025-08-07 7:01 ` Geert Uytterhoeven [this message]
2025-08-06 19:55 ` [PATCH v3 6/7] pinctrl: renesas: rzg2l: Add PFC_OEN support for RZ/G3E SoC Prabhakar
2025-08-07 7:02 ` Geert Uytterhoeven
2025-08-06 19:55 ` [PATCH v3 7/7] pinctrl: renesas: rzg2l: Drop oen_read and oen_write callbacks Prabhakar
2025-08-07 7:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdW=-O3NDjgNSGa8GFArp9wJ0CFRmbFbTKcZ-mW=TCiTOQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).