linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: Re: [PATCH] ARM: dts: renesas: gose: remove superfluous port property
Date: Mon, 29 Sep 2025 15:40:43 +0200	[thread overview]
Message-ID: <CAMuHMdWrMB5ZdRgX0BwLJeOgJPecxm_kw2J=RcFegdZgtHwtYA@mail.gmail.com> (raw)
In-Reply-To: <20250929093616.17679-2-wsa+renesas@sang-engineering.com>

Hi Wolfram,

CC Niklas

On Mon, 29 Sept 2025 at 11:36, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> 'bus-width' is defined for the corresponding vin input port already. No
> need to declare it in the output port again. Fixes:
>
> arch/arm/boot/dts/renesas/r8a7793-gose.dtb: composite-in@20 (adi,adv7180cp): ports:port@3:endpoint: Unevaluated properties are not allowed ('bus-width' was unexpected)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> @@ -373,7 +373,6 @@ adv7180_in: endpoint {
>                                 port@3 {
>                                         reg = <3>;
>                                         adv7180_out: endpoint {
> -                                               bus-width = <8>;
>                                                 remote-endpoint = <&vin1ep>;
>                                         };
>                                 };

I think r8a7791-koelsch.dts has the same issue, but currently it is
not flagged by dtbs_check because adi,adv7180 uses slightly different
and less modern DT bindings than adi,adv7180cp.
However, according to the schematics both Koelsch and Gose use
ADV7180WBCP32Z, so r8a7791-koelsch.dts should use adi,adv7180cp, too?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2025-09-29 13:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29  9:36 [PATCH] ARM: dts: renesas: gose: remove superfluous port property Wolfram Sang
2025-09-29 13:25 ` Geert Uytterhoeven
2025-09-29 13:31   ` Geert Uytterhoeven
2025-09-29 13:40 ` Geert Uytterhoeven [this message]
2025-09-29 21:14   ` Wolfram Sang
2025-10-03 21:55     ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWrMB5ZdRgX0BwLJeOgJPecxm_kw2J=RcFegdZgtHwtYA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).