From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA8AC63798 for ; Fri, 27 Nov 2020 15:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D76D20B80 for ; Fri, 27 Nov 2020 15:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730366AbgK0PgA (ORCPT ); Fri, 27 Nov 2020 10:36:00 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:34406 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728495AbgK0PgA (ORCPT ); Fri, 27 Nov 2020 10:36:00 -0500 Received: by mail-ot1-f66.google.com with SMTP id h19so5057526otr.1 for ; Fri, 27 Nov 2020 07:35:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QD8MwycA2iHmBUbtGsA4IDCl5CFvRwO65p9IbeYmjW4=; b=RipaJAxqkJLjOXLJ7MsGbN4UZhzHZHlY5qdVDWz3PCKS2Nt9cFaKmKQymAPeo8Eb5P bZfaKlEWPINGb6W+OIiI6o0Qo9piCekKydfvXLQ4jVxf5gMp/CxIDOW9XUI/xUrpskKO bBa2I4g113DNvG5drooBUvmmFtvwvSwdRCK0sEc474WhLSIPoLbYUtNw9e+h86m+kQTg x+7JFg0cXU33J5N74ndri1Q/CANzglP8/n1o7tGwDH4zqxfilA/qGybzVG1gbNOsFioz 759xEmyEVPLXikUkc43or3Wp47TUI5+toP3K5c6br5iN8fW18+i5+TMlE0XCUvbBtcp9 Telg== X-Gm-Message-State: AOAM531bG9fFHVsIQhIG0qO9o0g8uhXmAlU+Ao2fB1iZTyntDZyF/hjQ x0QvaiFoIBRaDEZZOF3ynPR5c+10tfi2QDPgCykwIPouzWA= X-Google-Smtp-Source: ABdhPJzNoZS0Dq5/UvJrEFjypis9AKn5Wf4ayzxHU8O9cMG4rPMXm1i2dszw6j9/YF54gmmGa4A87ugJlg7ErvlmIss= X-Received: by 2002:a05:6830:210a:: with SMTP id i10mr6250719otc.145.1606491359417; Fri, 27 Nov 2020 07:35:59 -0800 (PST) MIME-Version: 1.0 References: <20201126172154.25625-1-uli+renesas@fpond.eu> <20201126172154.25625-3-uli+renesas@fpond.eu> In-Reply-To: <20201126172154.25625-3-uli+renesas@fpond.eu> From: Geert Uytterhoeven Date: Fri, 27 Nov 2020 16:35:48 +0100 Message-ID: Subject: Re: [PATCH 02/11] pinctrl: renesas: r8a779a0: Add CANFD pins, groups and functions To: Ulrich Hecht Cc: Linux-Renesas , Wolfram Sang , hoai.luu.ub@renesas.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Uli, On Thu, Nov 26, 2020 at 6:22 PM Ulrich Hecht wrote: > This patch adds CANFD 0-7 and CANFD clock pinmux support for the > R8A779A0 (V3U) SoC. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > --- a/drivers/pinctrl/renesas/pfc-r8a779a0.c > +++ b/drivers/pinctrl/renesas/pfc-r8a779a0.c > +/* - CANFD Clock ------------------------------------------------------------ */ > +static const unsigned int canfd_clk_pins[] = { > + /* CAN_CLK */ > + RCAR_GP_PIN(3, 0), > +}; > +static const unsigned int canfd_clk_mux[] = { > + CAN_CLK_MARK, > +}; The User's Manual calls this "can_clk", so I'm wondering if we should do the same, like on most R-Car SoCs,to avoid confusing with the internal CANFD clock. I know we call it "canfd_clk" on R-Car V3M (it is called that way in the manual) and on R-Car V3H (either copied from V3M, or changed later in the manual), the two other SoCs that don't have separate (non-FD) CAN controllers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds