From: Ulf Hansson <ulf.hansson@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Dirk Behme <dirk.behme@gmail.com>
Subject: Re: [PATCH 0/4] tmio: add support for eMMC with 8 bit bus width
Date: Mon, 19 Sep 2016 12:00:04 +0200 [thread overview]
Message-ID: <CAPDyKFr3-BAAg9HYVY93rmjOfrBxpVTH4RLJeKotTVER6Padsg@mail.gmail.com> (raw)
In-Reply-To: <20160919080045.GA1409@katana>
On 19 September 2016 at 10:00, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Thu, Sep 15, 2016 at 01:52:26PM +0200, Geert Uytterhoeven wrote:
>> Hi Wolfram,
>>
>> On Wed, Sep 14, 2016 at 7:05 PM, Wolfram Sang
>> <wsa+renesas@sang-engineering.com> wrote:
>> > The DTS changes for R-Car Gen3 will come via a seperate series. Note that
>> > 'non-removable' is not supported yet because of Runtime PM issues. It seems we
>> > need to overhaul Runtime PM handling for other reasons as well, so I suggest
>> > the basic support goes in like this and DTS do not use 'non-removable' for now.
>>
>> DT describes the hardware, not current limitations of the software.
>> Hence IMHO you should add the "non-removable" property to the DTS, and
>> work around its non-functioning in software.
>
> @Ulf: Would you accept such a workaround for a while?
With some comments about why, yes!
Br
Uffe
>
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
> index f21c92ec7121cc..5ab8af294f7c40 100644
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
> @@ -1154,6 +1154,10 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host,
> !mmc_card_is_removable(mmc) ||
> mmc->slot.cd_irq >= 0);
>
> + /* Workaround for NONREMOVABLE until we fix RuntimePM handling */
> + if (pdata->flags & TMIO_MMC_MIN_RCAR2)
> + _host->native_hotplug = true;
> +
> if (tmio_mmc_clk_enable(_host) < 0) {
> mmc->f_max = pdata->hclk;
> mmc->f_min = mmc->f_max / 512;
>
prev parent reply other threads:[~2016-09-19 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 17:05 [PATCH 0/4] tmio: add support for eMMC with 8 bit bus width Wolfram Sang
2016-09-14 17:05 ` [PATCH 1/4] mmc: add define for R1 response without CRC Wolfram Sang
2016-09-14 17:05 ` [PATCH 2/4] mmc: rtsx_pci: use new macro for R1 " Wolfram Sang
2016-09-14 17:05 ` [PATCH 3/4] mmc: rtsx_usb: " Wolfram Sang
2016-09-14 17:05 ` [PATCH 4/4] mmc: tmio: add eMMC support Wolfram Sang
2016-09-15 11:52 ` [PATCH 0/4] tmio: add support for eMMC with 8 bit bus width Geert Uytterhoeven
2016-09-19 8:00 ` Wolfram Sang
2016-09-19 10:00 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFr3-BAAg9HYVY93rmjOfrBxpVTH4RLJeKotTVER6Padsg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=dirk.behme@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).